Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wallet_addEthereumChain Reference (Playground) Example #1112

Closed
httpJunkie opened this issue Jan 28, 2024 · 2 comments
Closed

Update wallet_addEthereumChain Reference (Playground) Example #1112

httpJunkie opened this issue Jan 28, 2024 · 2 comments
Assignees

Comments

@httpJunkie
Copy link
Contributor

The example for wallet_addEthereumChain currently gives the user warnings:
Screenshot 2024-01-28 at 2 26 09 PM

This example appears to have the correct parameters according to this link:
https://docs.gnosischain.com/tools/wallets/metamask/

That is why I have not simply submitted a PR with the correct parameters.
It would seem that whatever logic we are using to check:

  • The network name matches the chain ID
  • The submitted currency symbol matches what we expect for this chain ID
  • And that our records for the the submitted RPC URL matches a known provider

Is out of date or incorrect per Gnosis chain docs. We need to check the information we have stored and ensure it matches. But I am not sure which repo and PR this issue should be associated with.

@alexandratran
Copy link
Contributor

According to the Gnosis docs, looks like we should update the example RPC URL to https://rpc.gnosischain.com and symbol to XDAI. @joaniefromtheblock can you address this in your api-specs PR updating the examples?

@joaniekube
Copy link
Contributor

Closed with MetaMask/api-specs#207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants