You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The test function for the PhishingController was recently made async so that we can lazily update the configuration, rather than polling for updates on a set interval. This simplifies testing and MV3 compatibility. However it may cause a delay in how quickly MetaMask can respond to a blocked site by navigating away.
We should explore ways of speeding up this check, either at the product layer or here or both. For example, here we can check the configuration eagerly before getting the update, so that we only have a slow response time for newly blocked sites (at the expense of potentially blocking a recently-allowed site a single time).
The text was updated successfully, but these errors were encountered:
The project can now decide what to do for itself when the phishing lists are outdated. It can check right away using the outdated configuration, wait until it's updated, or it can check before and after.
The
test
function for the PhishingController was recently made async so that we can lazily update the configuration, rather than polling for updates on a set interval. This simplifies testing and MV3 compatibility. However it may cause a delay in how quickly MetaMask can respond to a blocked site by navigating away.We should explore ways of speeding up this check, either at the product layer or here or both. For example, here we can check the configuration eagerly before getting the update, so that we only have a slow response time for newly blocked sites (at the expense of potentially blocking a recently-allowed site a single time).
The text was updated successfully, but these errors were encountered: