Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate DHE test cases to ECDHE #9688

Closed
gilles-peskine-arm opened this issue Oct 11, 2024 · 1 comment
Closed

Migrate DHE test cases to ECDHE #9688

gilles-peskine-arm opened this issue Oct 11, 2024 · 1 comment
Assignees
Labels
component-tls size-xs Estimated task size: extra small (a few hours at most)

Comments

@gilles-peskine-arm
Copy link
Contributor

gilles-peskine-arm commented Oct 11, 2024

There are a few TLS 1.2 test cases where we're currently using a DHE key exchange, but we could indifferently use ECDHE. Since we are removing DHE, we need to migrate those test cases to ECDHE.

Remove the other test cases that force a DHE key exchange.

Definition of done:

  • Correctness: we don't lose test coverage, except specifically around DHE.
  • Completeness: there are no test cases in test_suite_ssl or ssl-opt that force DHE.

This applies to development only. But we may want to backport the new test cases as additional tests in 3.6 for a minor but very cheap coverage improvement.

To clarify the scope:

  • A test case that uses DHE because its objective is to test DHE should be removed.
  • A test case that uses DHE, for which there is another test case that's identical except for using ECDHE, should be removed.
  • A test case that uses DHE, but could do without it, and has no equivalent non-DHE test case, should be adapted.

The test cases that should be adapted, analyzed on 467edcd:

  • test_suite_ssl
    • resize_buffers_renegotiate_mfl: we're testing ECDHE-RSA with GCM, and DHE-RSA with CBC. I think there's no particular reason for that and in 4.0 we should just change thee DHE test cases to ECDHE.
  • ssl-opt.sh
    • "Opaque key for server authentication: DHE-RSA, PSS instead of PKCS1"
    • ""Opaque keys for server authentication: EC + RSA, force DHE-RSA" ? Not sure if other test cases reach the same path
    • "keyUsage cli 1.2: DigitalSignature+KeyEncipherment, DHE-RSA: OK"
    • "keyUsage cli 1.2: KeyEncipherment, DHE-RSA: fail (hard)"
    • "keyUsage cli 1.2: KeyEncipherment, DHE-RSA: fail (soft)"
    • "keyUsage cli 1.2: DigitalSignature, DHE-RSA: OK"
@ronald-cron-arm
Copy link
Contributor

Done by #9916

@github-project-automation github-project-automation bot moved this from Implementation needed to Done in Mbed TLS 4.0 planning Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-tls size-xs Estimated task size: extra small (a few hours at most)
Projects
Status: Done
Development

No branches or pull requests

3 participants