Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver-only curves: parity starter #7344

Closed
4 tasks
mpg opened this issue Mar 28, 2023 · 3 comments
Closed
4 tasks

Driver-only curves: parity starter #7344

mpg opened this issue Mar 28, 2023 · 3 comments
Assignees
Labels
enhancement size-s Estimated task size: small (~2d)

Comments

@mpg
Copy link
Contributor

mpg commented Mar 28, 2023

Context: see #6839.

Depends on: #7103

  • Create a reference component associated with the two components introduced in Some MAX_SIZE macros are too small when PSA ECC is accelerated #7103 (unless I'm mistaken, they can share the same reference component).
  • Add parity testing in analyze_outcomes.py for the two pairs ("only p192" vs ref, "only x25519" vs ref) - for now add as many "ignore" entries as needed to make it pass.
  • Do a local trial run of ssl-opt.sh (with parity) to get a feel of how it goes.
  • Adjust follow-up issues (might result in: closing as there's nothing to do, editing the description to reflect work to be done, changing the size estimate to "s" is there's little work to be done, splitting into multiple issues if there's a large amount of work, etc.) according to findings.

Note: this is similar to #6855, #7142 and #7255 except in this case there are two driver components and they have been added in #7103 already.

@valeriosetti
Copy link
Contributor

unless I'm mistaken, they can share the same reference component

I agree ;)

@valeriosetti
Copy link
Contributor

Do a local trial run of ssl-opt.sh (with parity) to get a feel of how it goes

I tried a quick run of ssl-opt.sh and it seems to me that a specific PR will be required since tests are failing since the very beginning with: SERVER START TIMEOUT

@mpg
Copy link
Contributor Author

mpg commented Apr 5, 2023

Closing as there's been a change of strategy, making this no longer relevant (for the time being at least), see #7241 (comment)

@mpg mpg closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size-s Estimated task size: small (~2d)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants