Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DES key derivation: reject weak keys #3259

Closed
gilles-peskine-arm opened this issue Mar 11, 2019 · 2 comments
Closed

DES key derivation: reject weak keys #3259

gilles-peskine-arm opened this issue Mar 11, 2019 · 2 comments
Labels
bug component-crypto Crypto primitives and low-level interfaces historical-reviewing Currently reviewing (for legacy PR/issues) priority-low Low priority - this may not receive review soon

Comments

@gilles-peskine-arm
Copy link
Contributor

gilles-peskine-arm commented Mar 11, 2019 •
edited
Loading

For DES, psa_key_derivation_output_key (formerly psa_generator_import_key()) should reject weak keys.

This is a theoretical bug since the chance of generating a weak key is 2^{-52}. It's only a problem for compliance and DES is no longer compliant in the US.
@ciarmcom
Copy link

Internal Jira reference: https://jira.arm.com/browse/IOTCRYPT-722

@gilles-peskine-arm gilles-peskine-arm transferred this issue from ARMmbed/mbed-crypto Apr 27, 2020
@gilles-peskine-arm gilles-peskine-arm added bug component-crypto Crypto primitives and low-level interfaces mbed TLS team labels Apr 27, 2020
@gilles-peskine-arm gilles-peskine-arm added the priority-low Low priority - this may not receive review soon label May 13, 2022
@tom-cosgrove-arm tom-cosgrove-arm added the historical-reviewing Currently reviewing (for legacy PR/issues) label Jan 27, 2023
@tom-cosgrove-arm
Copy link
Contributor

Given we are going to deprecate the entire DES module relatively soon, we're not going to do this

@tom-cosgrove-arm tom-cosgrove-arm closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug component-crypto Crypto primitives and low-level interfaces historical-reviewing Currently reviewing (for legacy PR/issues) priority-low Low priority - this may not receive review soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@daverodgman @ciarmcom @gilles-peskine-arm @tom-cosgrove-arm