Skip to content

Commit fda367e

Browse files
committed
changelog: fixed typos
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
1 parent 70f0bbc commit fda367e

4 files changed

+5
-5
lines changed

ChangeLog.d/improve_x509_cert_writing_serial_number_management.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ Bugfix
77
New deprecations
88
* mbedtls_x509write_crt_set_serial() is now being deprecated in favor of
99
mbedtls_x509write_crt_set_serial_new(). The goal here is to remove any
10-
direct dependency of X509 from BIGNUM_C.
10+
direct dependency of X509 on BIGNUM_C.

library/x509write_crt.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ int mbedtls_x509write_crt_set_serial( mbedtls_x509write_cert *ctx,
119119
MBEDTLS_X509_RFC5280_MAX_SERIAL_LEN );
120120
if( ret < 0 )
121121
return ret;
122-
122+
123123
/* Copy data to the internal structure skipping leading zeros */
124124
memcpy(ctx->serial, &tmp[MBEDTLS_X509_RFC5280_MAX_SERIAL_LEN - tmp_len],
125125
tmp_len);

tests/suites/test_suite_x509write.data

+1-1
Original file line numberDiff line numberDiff line change
@@ -169,4 +169,4 @@ X509 String to Names #6 (Escape at end)
169169
mbedtls_x509_string_to_names:"C=NL, O=Offspark\":"":MBEDTLS_ERR_X509_INVALID_NAME
170170

171171
Check max serial length
172-
x509_set_serial_check:
172+
x509_set_serial_check:

tests/suites/test_suite_x509write.function

+2-2
Original file line numberDiff line numberDiff line change
@@ -581,13 +581,13 @@ void x509_set_serial_check()
581581

582582
memset( invalid_serial, 0x01, sizeof( invalid_serial ) );
583583

584-
#if defined(MBEDTLS_BIGNUM_C) && !defined(MBEDTLS_DEPRECATED_REMOVED)
584+
#if defined(MBEDTLS_TEST_DEPRECATED) && defined(MBEDTLS_BIGNUM_C)
585585
mbedtls_mpi serial_mpi;
586586

587587
mbedtls_mpi_init(&serial_mpi);
588588
TEST_EQUAL( mbedtls_mpi_read_binary( &serial_mpi, invalid_serial,
589589
sizeof( invalid_serial ) ), 0 );
590-
TEST_EQUAL( mbedtls_x509write_crt_set_serial( &ctx, &serial_mpi ),
590+
TEST_EQUAL( mbedtls_x509write_crt_set_serial( &ctx, &serial_mpi ),
591591
MBEDTLS_ERR_X509_BAD_INPUT_DATA );
592592
mbedtls_mpi_free(&serial_mpi);
593593
#endif

0 commit comments

Comments
 (0)