-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove RNG parameters from LMS #182
base: development
Are you sure you want to change the base?
Remove RNG parameters from LMS #182
Conversation
18f743c
to
44a0fe7
Compare
9c49f5d
to
3c37aac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the changelog entry
ChangeLog.d/168.txt
Outdated
@@ -0,0 +1,3 @@ | |||
API changes | |||
* Remove the rng parameters from lms.* and lmots.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog is about the API, not about the internals, so only lms.h
is relevant (LMOTS isn't public).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As agreed I've removed the ChangeLog, as the plan is to produce a consolidated version once all RNG removal is complete.
ChangeLog.d/168.txt
Outdated
@@ -0,0 +1,3 @@ | |||
API changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make sense to have a single entry for all the RNG parameter removals, rather than separate entries for each module. We might as well write it now, something like
All API functions now use the PSA random generator (psa_get_random()) internally. As a consequence, functions no longer take RNG parameters.
Also, we should give the file a more meaningful name. (The file name doesn't matter in the end, but in the meantime it's easier to find a pending changelog entry in remove-rng-parameters-from-lms.txt
or remove-rng-parameters.txt
than in 168.txt
.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind this, as discussed this morning, let's not worry much about changelog entry organization at this stage. I've filed a separate issue to consolidate the documentation at the end. (I also added a task for the knowledge base, better do it now than forget later.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As agreed I've removed the ChangeLog, as the plan is to produce a consolidated version once all RNG removal is complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
…l rng removals are complete Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
a0b4ccc
to
3744f55
Compare
Description
Remove RNG parameters from LMS resolves #168
PR checklist