Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RNG parameters from LMS #182

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

bjwtaylor
Copy link

@bjwtaylor bjwtaylor commented Feb 25, 2025

Description

Remove RNG parameters from LMS resolves #168

PR checklist

  • changelog not required as we have agreed to add it it as another task once all rng removal has been completed.
  • framework PR not required
  • mbedtls PR not required because: API not used in mbedtls
  • mbedtls 3.6 PR not required because: API change
  • mbedtls 2.28 PR not required because: API change
  • tests not required because: no changes to test

@bjwtaylor bjwtaylor force-pushed the remove-rng-parameters-from-lms branch from 18f743c to 44a0fe7 Compare February 25, 2025 15:57
@bjwtaylor bjwtaylor marked this pull request as ready for review February 26, 2025 09:02
@bjwtaylor bjwtaylor added needs-review Every commit must be reviewed by at least two team members api-break This issue/PR breaks the API and must wait for a new major version labels Feb 26, 2025
@bjwtaylor bjwtaylor force-pushed the remove-rng-parameters-from-lms branch from 9c49f5d to 3c37aac Compare February 26, 2025 14:43
@minosgalanakis minosgalanakis requested review from minosgalanakis and removed request for minosgalanakis February 26, 2025 17:15
@gilles-peskine-arm gilles-peskine-arm added size-s Estimated task size: small (~2d) needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon labels Feb 27, 2025
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the changelog entry

@@ -0,0 +1,3 @@
API changes
* Remove the rng parameters from lms.* and lmots.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog is about the API, not about the internals, so only lms.h is relevant (LMOTS isn't public).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed I've removed the ChangeLog, as the plan is to produce a consolidated version once all RNG removal is complete.

@@ -0,0 +1,3 @@
API changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to have a single entry for all the RNG parameter removals, rather than separate entries for each module. We might as well write it now, something like

All API functions now use the PSA random generator (psa_get_random()) internally. As a consequence, functions no longer take RNG parameters.

Also, we should give the file a more meaningful name. (The file name doesn't matter in the end, but in the meantime it's easier to find a pending changelog entry in remove-rng-parameters-from-lms.txt or remove-rng-parameters.txt than in 168.txt.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind this, as discussed this morning, let's not worry much about changelog entry organization at this stage. I've filed a separate issue to consolidate the documentation at the end. (I also added a task for the knowledge base, better do it now than forget later.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed I've removed the ChangeLog, as the plan is to produce a consolidated version once all RNG removal is complete.

@gilles-peskine-arm gilles-peskine-arm added needs-work and removed needs-review Every commit must be reviewed by at least two team members needs-reviewer This PR needs someone to pick it up for review labels Feb 27, 2025
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members needs-reviewer This PR needs someone to pick it up for review and removed needs-work labels Mar 4, 2025
Ben Taylor added 3 commits March 5, 2025 10:41
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
…l rng removals are complete

Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
@bjwtaylor bjwtaylor force-pushed the remove-rng-parameters-from-lms branch from a0b4ccc to 3744f55 Compare March 5, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break This issue/PR breaks the API and must wait for a new major version needs-review Every commit must be reviewed by at least two team members needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Development

Successfully merging this pull request may close these issues.

Remove RNG parameters from LMS
2 participants