Skip to content

Refactor the worker, it's a mess! #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Matir opened this issue Jun 6, 2018 · 1 comment
Open

Refactor the worker, it's a mess! #40

Matir opened this issue Jun 6, 2018 · 1 comment

Comments

@Matir
Copy link
Owner

Matir commented Jun 6, 2018

The worker is a mess of spaghetti. Let's clean it up.
@Matir
Copy link
Owner Author

Matir commented Jun 7, 2018

Step 1: instead of mangling in the worker, we could pass the task to an expander that feeds into the workqueue.
Step 2: refactor the decision on whether to add dependent work into a separate function
Step 3: split error handling & result building into new functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Matir