Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users swift UI #16

Closed
wants to merge 5 commits into from
Closed

Users swift UI #16

wants to merge 5 commits into from

Conversation

patcesnek
Copy link

📝 Description

  • Remake Users and UserDetail views into SwiftUI

💡 What’s new?

  • The app after login displays SwiftUI view UsersView instead of UIViewController
  • On selecting user the app opens UserDetailView written in SwiftUI instead of UIKit version

😶 What’s missing?

📚 References

Copy link
Contributor

@tomas-bat tomas-bat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to build your code🤔 The flow controllers seem to be unchanged, still trying to initialise the UIKit versions of the views resulting in an error.

Other reason why the build fails on CI is that we're using Xcode 13.1 which does not support concurrency for iOS 13, same thing is happening in #17.

@pchmelar
Copy link
Member

Closing in favor of #30

@pchmelar pchmelar closed this May 23, 2022
@pchmelar pchmelar deleted the users-swift-ui branch May 23, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants