Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hidedecorations! for PolarAxis does not take protrusions into account #4822

Open
grero opened this issue Feb 25, 2025 · 1 comment · May be fixed by #4823
Open

hidedecorations! for PolarAxis does not take protrusions into account #4822

grero opened this issue Feb 25, 2025 · 1 comment · May be fixed by #4823
Labels

Comments

@grero
Copy link
Contributor

grero commented Feb 25, 2025

  • [ x ] what version of Makie are you running? (]st -m Makie)
]st -m Makie
Status `~/Documents/programming/julia/MakiePolarTest/Manifest.toml`
  [ee78f7c6] Makie v0.22.1
  • [ x ] can you reproduce the bug with a fresh environment ? (]activate --temp; add Makie)

  • [ x ] What platform + GPU are you on?
    Apple M1 Ultra macOS 15.0.1

MWE:

using Makie
using CairoMakie

function polar_test()
  r = 0.1 .+ randn(20)
  a = 2*pi*rand(20)
  fig = Figure(size=(600,300))
  ax1 = PolarAxis(fig[1,1])
  scatter!(ax1, a, r)
  hidedecorations!(ax1)
  ax1.thetagridvisible[] = true
  ax1.rgridvisible[] = true
  b1 = Box(fig[1, 1]; color = (:red, 0.3))

  ax2 = PolarAxis(fig[1,2])
  ax2.rticklabelsize[] = 0
  ax2.thetaticklabelsize[] = 0
  scatter!(ax2, a, r)
  b2 = Box(fig[1, 2]; color = (:red, 0.3))
  resize_to_layout!(fig)
fig
end

polar_test()

Image

In the left panel, hidedecorations! does not cause the axis to fill all available space, while in the right, explicitly setting the r and theta ticklabelsizes to 0 achieves the desired effect.

@grero grero added the bug label Feb 25, 2025
@asinghvi17
Copy link
Member

It's still not quite perfect, something could use some tuning

@ffreyer ffreyer linked a pull request Feb 25, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants