Fix some cpp check and clazy warnings

Author: andibacher

examples/basic/main.cpp

@@ -48,8 +48,8 @@ int main(int argc, char *argv[])
 {
     QCoreApplication application(argc, argv);
 
-    auto *object = new LoggerObject(&application);
-    auto *object1 = new LoggerObjectPrio(&application);
+    const auto *object = new LoggerObject(&application);
+    const auto *object1 = new LoggerObjectPrio(&application);
     Q_UNUSED(object1)
     QLoggingCategory::setFilterRules("*.debug=false\n"
                                          "test.category1.debug=true");

examples/propertyconfigurator/main.cpp

@@ -45,8 +45,8 @@ int main(int argc, char *argv[])
 {
     QCoreApplication application(argc, argv);
 
-    auto *object = new LoggerObject(&application);
-    auto *object1 = new LoggerObjectPrio(&application);
+    const auto *object = new LoggerObject(&application);
+    const auto *object1 = new LoggerObjectPrio(&application);
     Q_UNUSED(object1)
 
     QObject::connect(object, &LoggerObject::exit, &application, &QCoreApplication::exit);

src/log4qt/appenderskeleton.cpp

@@ -167,7 +167,7 @@ void AppenderSkeleton::customEvent(QEvent *event)
 {
     if (event->type() == LoggingEvent::eventId)
     {
-        auto logEvent = static_cast<LoggingEvent *>(event);
+        const auto logEvent = static_cast<LoggingEvent *>(event);
         doAppend(*logEvent);
         return ;
     }
@@ -197,7 +197,7 @@ void AppenderSkeleton::doAppend(const LoggingEvent &event)
     if (!isAsSevereAsThreshold(event.level()))
         return;
 
-    Filter  *filter = mpHeadFilter.data();
+    const auto  *filter = mpHeadFilter.data();
     while (filter)
     {
         Filter::Decision decision = filter->decide(event);

src/log4qt/helpers/initialisationhelper.cpp

@@ -41,7 +41,7 @@ namespace Log4Qt
 {
 
 InitialisationHelper::InitialisationHelper() :
-    mStartTime(QDateTime::currentDateTime().toMSecsSinceEpoch())
+    mStartTime(QDateTime::currentMSecsSinceEpoch())
 {
     doRegisterTypes();
     doInitialiseEnvironmentSettings();

src/log4qt/loggingevent.cpp

@@ -44,7 +44,7 @@ LoggingEvent::LoggingEvent() :
     mProperties(MDC::context()),
     mSequenceNumber(nextSequenceNumber()),
     mThreadName(),
-    mTimeStamp(QDateTime::currentDateTime().toMSecsSinceEpoch())
+    mTimeStamp(QDateTime::currentMSecsSinceEpoch())
 {
     setThreadNameToCurrent();
 }
@@ -62,7 +62,7 @@ LoggingEvent::LoggingEvent(const Logger *logger,
     mProperties(MDC::context()),
     mSequenceNumber(nextSequenceNumber()),
     mThreadName(),
-    mTimeStamp(QDateTime::currentDateTime().toMSecsSinceEpoch())
+    mTimeStamp(QDateTime::currentMSecsSinceEpoch())
 {
     setThreadNameToCurrent();
 }
@@ -80,7 +80,7 @@ LoggingEvent::LoggingEvent(const Logger *logger,
        mProperties(MDC::context()),
        mSequenceNumber(nextSequenceNumber()),
        mThreadName(),
-       mTimeStamp(QDateTime::currentDateTime().toMSecsSinceEpoch()),
+       mTimeStamp(QDateTime::currentMSecsSinceEpoch()),
        mContext(context),
        mCategoryName(categoryName)
 {

src/log4qt/propertyconfigurator.cpp

@@ -560,7 +560,7 @@ void PropertyConfigurator::startCaptureErrors()
 bool PropertyConfigurator::stopCaptureErrors()
 {
     Q_ASSERT_X(mpConfigureErrors, "PropertyConfigurator::stopCaptureErrors()", "mpConfigureErrors must not be empty.");
-    auto *listAppender = static_cast<ListAppender *>(mpConfigureErrors.data());
+    const auto *listAppender = static_cast<ListAppender *>(mpConfigureErrors.data());
     LogManager::logLogger()->removeAppender(mpConfigureErrors);
     ConfiguratorHelper::setConfigureError(listAppender->list());
     bool result = (listAppender->list().count() == 0);

tests/dailyfileappendertest/dailyfileappendertest.cpp

@@ -36,7 +36,7 @@ class DailyFileAppenderTest : public QObject
 {
     Q_OBJECT
 public:
-    DailyFileAppenderTest(QObject * parent = nullptr) :
+    explicit DailyFileAppenderTest(QObject * parent = nullptr) :
                                 QObject(parent),
                                 mLogDirectory(nullptr),
                                 mAppender(nullptr) {}

tests/filewatcher/tst_filewatchertest.cpp

@@ -1,10 +1,10 @@
-#include <QString>
-#include <QtTest>
 #include <QFile>
 #include <QSaveFile>
-#include <QTemporaryFile>
+#include <QString>
 #include <QTemporaryDir>
+#include <QTemporaryFile>
 #include <QTextStream>
+#include <QtTest>
 
 #include "log4qt/helpers/configuratorhelper.h"