Allow building on spir-v #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lokathor
reviewed
Jun 11, 2021
DJMcNab
added a commit
to DJMcNab/rust-gpu
that referenced
this pull request
Jun 11, 2021
This works simply by naming the binary crate anything other than the name of the lib, which is example-runner-wgpu As far as I know, the warning started in EmbarkStudios#215 Since there is only one binary crate in the package, the command (`cargo run -p example-runner-wgpu --release`) maintains the same behaviour The cargo issue is rust-lang/cargo#6313 This warning caused problems for me in testing Lokathor/bytemuck#67 since I didn't notice the warning that my patch was not applied
|
I'll try to do a patch release later today. |
|
1.6.1 is out |
|
Thanks for the swift release. |
khyperia
pushed a commit
to EmbarkStudios/rust-gpu
that referenced
this pull request
Jun 14, 2021
This works simply by naming the binary crate anything other than the name of the lib, which is example-runner-wgpu As far as I know, the warning started in #215 Since there is only one binary crate in the package, the command (`cargo run -p example-runner-wgpu --release`) maintains the same behaviour The cargo issue is rust-lang/cargo#6313 This warning caused problems for me in testing Lokathor/bytemuck#67 since I didn't notice the warning that my patch was not applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows this crate to be used on the gpu side for rust-gpu
This removes a roadblock from using crevice on the gpu side, and prevents confusing errors.
Complementary PR to EmbarkStudios/rust-gpu#668