Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont pass transaction in URL in multi signature continuous flow #5374

Closed
oskarleonard opened this issue Oct 12, 2023 · 0 comments
Closed

Dont pass transaction in URL in multi signature continuous flow #5374

oskarleonard opened this issue Oct 12, 2023 · 0 comments
Assignees
@oskarleonard
Labels
type: improvement
Milestone
Sprint 110

Comments

@oskarleonard
Copy link
Contributor

Description

When switching account in a continuous multi sig flow we currently pass (This PR) the transaction url as a url params.

It would be better if we use:

  1. Url state (Dont think it will work since we link to a modal)
  2. Redux for this temporary state

Motivation

  • Current way creates a messy URL and could probably cause problems when a lot of multi signature accounts since url params have a limit of 2048 character.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarleonard oskarleonard

Labels
type: improvement
Projects
No open projects
Lisk Desktop Version 3.0.0
Status: Done
Milestone
Sprint 110
Development

No branches or pull requests
2 participants
@ManuGowda @oskarleonard