Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lisk-desktop: incorrect props passed #5193

Closed
ManuGowda opened this issue Jul 20, 2023 · 0 comments · Fixed by #5203
Closed

Lisk-desktop: incorrect props passed #5193

ManuGowda opened this issue Jul 20, 2023 · 0 comments · Fixed by #5203
Assignees
@oskarleonard
Labels
type: bug
Milestone
Sprint 104

Comments

@ManuGowda
Copy link
Contributor

ManuGowda commented Jul 20, 2023 •
edited
Loading

Expected behavior

This likely happens in many other components; so, we recommend creating a CodeQL rule (or similar) to find other similar cases.

Actual behavior

The CustomRoute component is called in the MainRouter.js file with a key and route property the CustomRouter does not use. Furthermore, the t parameter is not passed in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarleonard oskarleonard

Labels
type: bug
Projects
No open projects
Lisk Desktop Version 3.0.0
Status: Done
Milestone
Sprint 104
Development

Successfully merging a pull request may close this issue.

Lisk-desktop: incorrect props passed LiskHQ/lisk-desktop
3 participants
@ManuGowda @oskarleonard @sridharmeganathan