Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lisk-desktop: lack of string internationalization #5189

Closed
ManuGowda opened this issue Jul 20, 2023 · 0 comments
Closed

Lisk-desktop: lack of string internationalization #5189

ManuGowda opened this issue Jul 20, 2023 · 0 comments
Assignees
@eniolam1000752
Labels
type: bug
Milestone
Sprint 105

Comments

@ManuGowda
Copy link
Contributor

ManuGowda commented Jul 20, 2023 •
edited
Loading

Expected behavior

Most strings in lisk-desktop are internationalized to facilitate the application’s use in different languages. However, 30 different strings are hardcoded and lack internationalization; for example, the string “Create one now” in AddAccountOptions.

We recommend running the i18next.jsx-not-internationalized Semgrep rule to find and fix these issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eniolam1000752 eniolam1000752

Labels
type: bug
Projects
No open projects
Lisk Desktop Version 3.0.0
Status: Done
Milestone
Sprint 105
Development

No branches or pull requests
4 participants
@ManuGowda @oskarleonard @eniolam1000752 @sridharmeganathan