Impossible to cancel a WalletConnect approval request without refreshing

[ManuGowda]

Description

When a user rejects a WalletConnect connection, they cannot add another one until they close and reopen the desktop application because the old connection event is never deleted. This happens because the reject handler does not call removeEvent(proposalEvents) like the approve function does.

const approve = useCallback( async (selectedAccounts) => {
const proposalEvents = events.find((e) => e.name === EVENTS.SESSION_PROPOSAL);
try {
const status = await onApprove(proposalEvents.meta, selectedAccounts);
removeEvent(proposalEvents);
setSessionProposal( null );
setSessionRequest( null );
// [REDACTED]
}, []);

const reject = useCallback( async () => {
const proposalEvents = events.find((e) => e.name === EVENTS.SESSION_PROPOSAL);
try {
await onReject(proposalEvents.meta);
setSessionProposal( null );
setSessionRequest( null );
// [REDACTED]
}, []);

lisk-desktop/libs/wcm/hooks/useSession.js

Lines 37 to 73 in 8238f41

	const approve = useCallback(async (selectedAccounts) => {
	const proposalEvents = events.find((e) => e.name === EVENTS.SESSION_PROPOSAL);
	try {
	const status = await onApprove(proposalEvents.meta, selectedAccounts);
	removeEvent(proposalEvents);
	setSessionProposal(null);
	setSessionRequest(null);
	await loadSessions();
	return {
	status,
	data: proposalEvents.meta,
	};
	} catch (e) {
	return {
	status: STATUS.FAILURE,
	message: e.message,
	};
	}
	}, []);
	const reject = useCallback(async () => {
	const proposalEvents = events.find((e) => e.name === EVENTS.SESSION_PROPOSAL);
	try {
	await onReject(proposalEvents.meta);
	setSessionProposal(null);
	setSessionRequest(null);
	return {
	status: STATUS.SUCCESS,
	data: proposalEvents.meta,
	};
	} catch (e) {
	return {
	status: STATUS.FAILURE,
	message: e.message,
	};
	}
	}, []);

Recommendation

Clear the event from the list of events on both approval and rejection. This will ensure that a processed event is not shown to the user again.

Which version(s) does this affect? (Environment, OS, etc...)

3.0