Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Update memdown to the latest version 🚀 #646

Merged
merged 1 commit into from
Mar 30, 2019

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Mar 30, 2019

The devDependency memdown was updated from 3.0.0 to 4.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Release Notes for v4.0.0

If you are upgrading: please see UPGRADING.md.

Changed

Added

Removed

Fixed

Commits

The new version differs by 28 commits.

  • 6e2db2f 4.0.0
  • f122c87 Prepare 4.0.0 (#181)
  • d3101e3 Merge pull request #174 from Level/greenkeeper/abstract-leveldown-6.0.0
  • 155ca81 Remove rimraf devDependency (closes #114)
  • fdb52a7 Document that nullish values are now also rejected
  • 04e32ff Test negative and positive Infinity as keys
  • ee0f133 Don't use falsy or undefined as not-defined signal
  • f9ed695 Remove now irrelevant serialization of nullish values
  • 552f501 Remove dummy location from abstract-leveldown constructor call
  • 2e1caf5 Use level-concat-iterator and testCommon.factory() in custom tests
  • 35b97ee Invoke abstract tests from single function
  • a5a07f9 Upgrade abstract-leveldown from ~5.0.0 to ~6.0.1
  • 282b3f8 chore(package): update nyc to version 13.2.0 (#180)
  • 51dddb6 Apply common project tweaks (round 2) (#179)
  • 40d022f Apply common project tweaks (#178)

There are 28 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@vweevers vweevers mentioned this pull request Mar 30, 2019
@vweevers
Copy link
Member

Gotta update a test:

ok 79 null & undefined keys & values: null and undefined: put() with null value works
/home/travis/build/Level/[secure]/node_modules/referee/lib/referee.js:204
            throw exception;
            ^
AssertionError: [refute] Expected WriteError: value cannot be `null` or `undefined` to be falsy
    at Object.referee.fail (/home/travis/build/Level/[secure]/node_modules/referee/lib/referee.js:193:25)
    at referee.refute (/home/travis/build/Level/[secure]/node_modules/referee/lib/referee.js:180:21)
    at /home/travis/build/Level/[secure]/test/null-and-undefined-test.js:74:9
    at /home/travis/build/Level/[secure]/lib/[secure].js:8:7082
    at _combinedTickCallback (internal/process/next_tick.js:77:11)
    at process._tickCallback (internal/process/next_tick.js:104:9)

@vweevers vweevers force-pushed the greenkeeper/memdown-4.0.0 branch from 4f08716 to 439117d Compare March 30, 2019 18:09
@@ -69,28 +69,28 @@ buster.testCase('null & undefined keys & values', {
done()
},

'put() with null value works': function (done) {
'put() with null value causes error': function (done) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird we still have these tests because this behavior is not defined by levelup but by the implementation of abstract-leveldown that is passed in.

Soon..

@vweevers vweevers merged commit 03dd06d into master Mar 30, 2019
@vweevers vweevers deleted the greenkeeper/memdown-4.0.0 branch March 30, 2019 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant