Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Update encoding-down to the latest version 🚀 #629

Merged
merged 2 commits into from
Dec 25, 2018

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Dec 25, 2018

The devDependency encoding-down was updated from 5.0.4 to 6.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Release Notes for v6.0.0

Changed

Added

Removed

Commits

The new version differs by 12 commits.

  • e5898b1 6.0.0
  • 2113cc0 run remark
  • 55dd2ed Prepare changelog and upgrade guide for 6.0.0 (#73)
  • cc24492 Remove _setupIteratorOptions (#74)
  • e9ac247 Explain serialization (#72)
  • a517afb const -> var in README
  • 7daad9c fix(package): update abstract-leveldown to version 6.0.0 (#68)
  • 55074e9 Merge pull request #66 from Level/greenkeeper/standard-12.0.0
  • d1b4bf5 chore(package): update standard to version 12.0.0
  • 3dee483 Add nyc and coveralls (#64)
  • 0467fd0 Remove node 9
  • d0a8658 use full link references in readme (#60)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@vweevers
Copy link
Member

Tests need updating.

@vweevers vweevers self-assigned this Dec 25, 2018
@vweevers
Copy link
Member

vweevers commented Dec 25, 2018

The failing test is not related to encoding-down. Why didn't the test fail before? 🤔

I think we're hitting a race issue because of the new nullish check in deferred-leveldown that only happens on an opening levelup instance.

No, it happens because the test wraps memdown with encoding-down.

@vweevers vweevers removed their assignment Dec 25, 2018
@vweevers vweevers merged commit fc5487c into master Dec 25, 2018
@vweevers vweevers deleted the greenkeeper/encoding-down-6.0.0 branch December 25, 2018 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants