Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Function to Replace Profile Index #237

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add Function to Replace Profile Index #237

wants to merge 2 commits into from

Conversation

michaelmckinsey1
Copy link
Collaborator

Resolves #233.

@michaelmckinsey1
Copy link
Collaborator Author

michaelmckinsey1 commented Jan 23, 2025 •
edited
Loading

depends on #235

@michaelmckinsey1 michaelmckinsey1 added area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs status-blocked PR is temporarily blocked from merge type-feature Requests for new features or PRs which implement new features labels Jan 23, 2025
@michaelmckinsey1 michaelmckinsey1 self-assigned this Jan 23, 2025
@michaelmckinsey1 michaelmckinsey1 marked this pull request as draft January 23, 2025 20:59
@michaelmckinsey1
Copy link
Collaborator Author

michaelmckinsey1 commented Jan 23, 2025 •
edited
Loading

Need to add check that new column is unique
8cbb70a

@michaelmckinsey1 michaelmckinsey1 mentioned this pull request Feb 14, 2025
Open
@michaelmckinsey1 michaelmckinsey1 marked this pull request as ready for review February 14, 2025 00:28
@slabasan slabasan added this to the 2025.1.0 milestone Feb 14, 2025
@michaelmckinsey1 michaelmckinsey1 added status-ready-to-merge This PR has made all revisions and is ready to merge into the develop branch and removed status-blocked PR is temporarily blocked from merge labels Feb 14, 2025
ilumsden
ilumsden approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@ilumsden ilumsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slabasan slabasan slabasan approved these changes

@ilumsden ilumsden ilumsden approved these changes

Assignees

@michaelmckinsey1 michaelmckinsey1

Labels
area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs status-ready-to-merge This PR has made all revisions and is ready to merge into the develop branch type-feature Requests for new features or PRs which implement new features
Projects
None yet
Milestone
2025.1.0
Development

Successfully merging this pull request may close these issues.

Add a function to replace the "profile" index level with a metadata column
3 participants
@michaelmckinsey1 @slabasan @ilumsden