Skip to content

Commit d11383a

Browse files
authored
chore(non-empty-alt): use virtualNode instead of node (dequelabs#1925)
1 parent 8c5f9ef commit d11383a

File tree

2 files changed

+10
-20
lines changed

2 files changed

+10
-20
lines changed

lib/checks/shared/non-empty-alt.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
var label = node.getAttribute('alt');
1+
const label = virtualNode.attr('alt');
22
return !!(label ? axe.commons.text.sanitize(label).trim() : '');

test/checks/shared/non-empty-alt.js

+9-19
Original file line numberDiff line numberDiff line change
@@ -2,39 +2,29 @@ describe('non-empty-alt', function() {
22
'use strict';
33

44
var fixture = document.getElementById('fixture');
5+
var checkSetup = axe.testUtils.checkSetup;
56

67
afterEach(function() {
78
fixture.innerHTML = '';
89
});
910

1011
it('should return true if an alt is present', function() {
11-
var node = document.createElement('img');
12-
node.setAttribute('alt', 'woohoo');
13-
fixture.appendChild(node);
14-
15-
assert.isTrue(checks['non-empty-alt'].evaluate(node));
12+
var params = checkSetup('<img id="target" alt="woohoo" />');
13+
assert.isTrue(checks['non-empty-alt'].evaluate.apply(null, params));
1614
});
1715

1816
it('should return false if an alt is not present', function() {
19-
var node = document.createElement('img');
20-
fixture.appendChild(node);
21-
22-
assert.isFalse(checks['non-empty-alt'].evaluate(node));
17+
var params = checkSetup('<img id="target" />');
18+
assert.isFalse(checks['non-empty-alt'].evaluate.apply(null, params));
2319
});
2420

2521
it('should return false if an alt is present, but empty', function() {
26-
var node = document.createElement('img');
27-
node.setAttribute('alt', ' ');
28-
fixture.appendChild(node);
29-
30-
assert.isFalse(checks['non-empty-alt'].evaluate(node));
22+
var params = checkSetup('<img id="target" alt=" " />');
23+
assert.isFalse(checks['non-empty-alt'].evaluate.apply(null, params));
3124
});
3225

3326
it('should collapse whitespace', function() {
34-
var node = document.createElement('div');
35-
node.setAttribute('alt', ' \t \n \r \t \t\r\n ');
36-
fixture.appendChild(node);
37-
38-
assert.isFalse(checks['non-empty-alt'].evaluate(node));
27+
var params = checkSetup('<img id="target" alt=" \t \n \r \t \t\r\n " />');
28+
assert.isFalse(checks['non-empty-alt'].evaluate.apply(null, params));
3929
});
4030
});

0 commit comments

Comments
 (0)