Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K2] In case of multiple inheritance overriden methods from superclass missed #3686

Closed
atyrin opened this issue Jul 9, 2024 · 4 comments · Fixed by #3718
Closed

[K2] In case of multiple inheritance overriden methods from superclass missed #3686

atyrin opened this issue Jul 9, 2024 · 4 comments · Fixed by #3718
Assignees
Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888

Comments

@atyrin
Copy link
Contributor

atyrin commented Jul 9, 2024

In the scenario below ChildWithTwoParent misses toString method on it's page in K2

open class FirstParent {
    fun basicMethod() = "OK"
    override fun toString(): String {
        return super.toString()
    }
}

interface ISecondParent {}

class ChildWithOneParent : FirstParent()
class ChildWithTwoParent : FirstParent(), ISecondParent

K2
image


K1
image


Installation

  • Dokka version: 2.0.0
@atyrin atyrin added bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888 labels Jul 9, 2024
@vmishenev
Copy link
Contributor

It is worth to test with non-toString.

@vmishenev vmishenev self-assigned this Jul 29, 2024
@atyrin
Copy link
Contributor Author

atyrin commented Feb 5, 2025

A minor thing: The toString method appeared in K2, but I see that we missed override keyword.
I don't see the same problem for regular methods.

@vmishenev
Copy link
Contributor

Related: #3848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants