Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K2] Duplication in logging for unresolved samples reference #3383

Closed
atyrin opened this issue Nov 28, 2023 · 2 comments · Fixed by #3776
Closed

[K2] Duplication in logging for unresolved samples reference #3383

atyrin opened this issue Nov 28, 2023 · 2 comments · Fixed by #3776
Assignees
Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Milestone

Comments

@atyrin
Copy link
Contributor

atyrin commented Nov 28, 2023

Create a declaration with a sample tag that will not be correctly resolved.

> Task :single-target-mpp-module:dokkaHtmlPartial
Initializing plugins
Dokka is performing: documentation for Single Target
Validity check
Creating documentation models
Couldn't resolve link for org.jetbrains.qa.runSample in KJvmClass.kt/org.jetbrains.qa.common.withSampleAsCallThisFun
Transforming documentation model before merging
Merging documentation models
Transforming documentation model after merging
Creating pages
Transforming pages
Unable to resolve a @sample link: "org.jetbrains.qa.runSample". Is it used correctly? Expecting a link to a reachable (resolvable) top-level Kotlin function.
Rendering
Running post-actions

The one unresolved reference here is mentioned twice.
If one diagnostic can be dropped, then I will notice that the first one is more presence as it has the location of the function.

Installation

  • Dokka version: 1.9.20
@atyrin atyrin added bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888 labels Nov 28, 2023
@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented Jan 19, 2024

Needs to be discussed as part of #2944

There might be more cases with similar errors, and it looks like we need to make a decision on how to approach these issues.

Similar cases:

@whyoleg
Copy link
Collaborator

whyoleg commented Aug 23, 2024

Action point:

  • do it before K2 opt-in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants