-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Standardize ZDO. #1194
feat!: Standardize ZDO. #1194
Conversation
Regarding #1183 (and accompanying issues)
Here is a sample of the logs in action with
Note that if the device sends other ZCL payloads during the time it takes for the response to come in, these will be ignored to prevent spamming. |
Zigbee herdsman is completely stubbed in z2m and since the interface didn't change this should be OK. |
Move ZDO requests out of Adapter to standardize execution.
All sending of standard ZDO requests is done via
sendZdo
.ZDO responses are emitted from Adapter to Controller, where common logic can be executed as needed. Removes the need for separate events.
Also worth mentioning:
controller.test.ts
for easier future updates.TODO separate PR:
deviceAnnounce
andnetworkAddress
event fromAdapter
Adapter
& impl.Controller
ember
zstack
permitJoin
special-case (later PR? in conjunction with [Proposal] Removal of "forever" Permit Join #940)