fix: zigate: parse all values as big endian #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devbis
force-pushed
the
zigate-big-endian
branch
from
b7f04e8 to
e21d465
Compare
|
@Koenkk it would be nice to see this fix merged in the next release as the long as addresses are broken in 1.39.1 for Zigate |
|
Thanks, it will be part of the next release! |
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NXP chips are big-endian, so all serial communication is going in big endian multi-byte values.
I changed all conversions to Big Endian which simplifies the code and also fixes reversed IEEE addresses.
Fixes: #1169