Update tuya.ts #8099
Merged
Update tuya.ts #8099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Oct 10, 2024
src/devices/tuya.ts
Outdated
| return {up: 1, down: 2}; | ||
| }, | ||
| exposes: [ | ||
| e.cover_position().withEndpoint('up'), |
There was a problem hiding this comment.
It's not nice that also these exposes are under an endpoint. I propose to modify tz.tuya_cover_calibration instead to support up and down calibration. (e.g. calibration_up, calibration_down). Then we can also keep this in the original TS130F definition (add calibration_up and calibration_down exposes conditionally in the exposes function)
There was a problem hiding this comment.
I have implemented the feature following your suggestion.
I also update fz.tuya_cover_options with calibration_time_up and calibration_time_down
Koenkk
reviewed
Oct 13, 2024
src/converters/fromZigbee.ts
Outdated
| const value = parseFloat(msg.data['moesCalibrationTime']) / 10.0; | ||
| result[postfixWithEndpointName('calibration_time', msg, model, meta)] = value; | ||
| if (endpoint === 2) { |
There was a problem hiding this comment.
Let's only expose calibration time up/down for ``:
if (meta.device.manufacturerName === '_TZ3000_cet6ch1r') {
..
} else {
..
}
Add support for calibration time up and down in tuya_cover_options Signed-off-by: Jonathan Sciarrabba <sciarrabba.j00@gmail.com>
Add support for calibration up and down in tuya_cover_calibration Signed-off-by: Jonathan Sciarrabba <sciarrabba.j00@gmail.com>
Add support for Tuya TS130F _TZ3000_cet6ch1r, it supports different calibration times for up and down Signed-off-by: Jonathan Sciarrabba <sciarrabba.j00@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for LoraTap SC400ZB-EU, same as LoraTap SC400 but supports different calibration times for up and down