fix: lumiOutageCountRestoreBindReporting sometimes stuck

[sjorge]

I noticed I was getting bind errors over and over again, due to timeouts.

There seems to have been some changes in zh, maybe in the past these did not propagate properly to zhc?

When the device recovers from a power outage (aka sometimes battery voltages dips when for example it refreshes the eInk display. We try and restore the bind/reporting settings, generally the device is awake for a bit after this happens before going to sleep.

If we somehow end up hitting a timeout, meta.outageCount was never updates because the bind and/or reporting hit an error. So we try again every message we get, but on a normal message the device does not seem to be awake for long to finish all the bind/reporting restores. So we end up where we started.

We can 'avoid' this by updating meta.outageCount first and adding a try {} catch {} around the bind/reporting restores.

This seems to be doing OK for the 2 power outages I triggered. Will monitor for a few days.

[sjorge]

Well I tried 3 times and could not trigger a failure (of course I can't when I want one)... at least the restoring is still working :)

[2024-07-27 14:16:08] debug:    zh:controller:endpoint: Bind 0x54ef441000781c8d/1 genPowerCfg from '0x00124b00228120b5/1'
[2024-07-27 14:16:09] debug:    zh:controller:endpoint: Bind 0x54ef441000781c8d/1 genAnalogInput from '0x00124b00228120b5/1'
[2024-07-27 14:16:11] debug:    zh:controller:endpoint: Bind 0x54ef441000781c8d/1 msTemperatureMeasurement from '0x00124b00228120b5/1'
[2024-07-27 14:16:12] debug:    zh:controller:endpoint: Bind 0x54ef441000781c8d/1 msRelativeHumidity from '0x00124b00228120b5/1'
[2024-07-27 14:16:13] debug:    zh:controller:endpoint: Bind 0x54ef441000781c8d/1 msTemperatureMeasurement from '0x001fee0000009911/1'
[2024-07-27 14:16:15] debug:    zh:controller:endpoint: ZCL command 0x54ef441000781c8d/1 genPowerCfg.configReport([{"attribute":"batteryVoltage","minimumReportInterval":3600,"maximumReportInterval":65000,"reportableChange":0}], {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null,"writeUndiv":false})
[2024-07-27 14:16:15] debug:    zh:controller:endpoint: Request Queue (0x54ef441000781c8d/1): send request
[2024-07-27 14:16:16] debug:    zh:controller:endpoint: ZCL command 0x54ef441000781c8d/1 genAnalogInput.configReport([{"attribute":"presentValue","minimumReportInterval":60,"maximumReportInterval":600,"reportableChange":10}], {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null,"writeUndiv":false})
[2024-07-27 14:16:16] debug:    zh:controller:endpoint: Request Queue (0x54ef441000781c8d/1): send request
[2024-07-27 14:16:17] debug:    zh:controller:endpoint: ZCL command 0x54ef441000781c8d/1 msTemperatureMeasurement.configReport([{"attribute":"measuredValue","minimumReportInterval":60,"maximumReportInterval":600,"reportableChange":10}], {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null,"writeUndiv":false})
[2024-07-27 14:16:17] debug:    zh:controller:endpoint: Request Queue (0x54ef441000781c8d/1): send request
[2024-07-27 14:16:18] debug:    zh:controller:endpoint: ZCL command 0x54ef441000781c8d/1 msRelativeHumidity.configReport([{"attribute":"measuredValue","minimumReportInterval":60,"maximumReportInterval":600,"reportableChange":10}], {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null,"writeUndiv":false})
[2024-07-27 14:16:18] debug:    zh:controller:endpoint: Request Queue (0x54ef441000781c8d/1): send request

[sjorge]

Seems good, outage count of device + db match and there has been no repeat attempts to restore binds.

sjorge@amethyst:~$ grep -c 'Restoring binding and reporting' /var/log/zigbee2mqtt.log
0

Good to go in.

[Koenkk]

thanks!