Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lf94/pause improvements #3032

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Lf94/pause improvements #3032

merged 3 commits into from
Jul 17, 2024

Conversation

lf94
Copy link
Contributor

@lf94 lf94 commented Jul 15, 2024

  • Idle mode is by default off (at least for now)
  • Idle mode is behind a setting (user or project)
  • A little "paused" with a pause button shows up now on idle teardown

@lf94 lf94 requested review from franknoirot and Irev-Dev July 15, 2024 20:54
Copy link

qa-wolf bot commented Jul 15, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jul 15, 2024 9:15pm

@lf94
Copy link
Contributor Author

lf94 commented Jul 15, 2024

We need to still iron out disabling all UI elements when the stream is paused, but that's a boarder PR I think.

@Irev-Dev Irev-Dev merged commit 482833c into main Jul 17, 2024
19 of 21 checks passed
@Irev-Dev Irev-Dev deleted the lf94/pause-improvements branch July 17, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants