-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/taxonomy #79
Feature/taxonomy #79
Conversation
Looks like I have an issue in the test scripts since merging in the latest master branch. I'll go back and figure out how to exclude the taxonomy from these tests because languages, tracing, and resolvers are not relevant to the taxonomy support. |
I made a new pull request that implements this in a similar way. There are some formatting fixes, I added in tests in gatsby-node and added validation. Mine still doesn’t resolve the unnecessary tests in languages and resolvers failing the build though. |
@NathanDCox - looks like we're working on the same thing then. |
# Conflicts: # package-lock.json
Hi @Simply007 , all is up to date now with passing tests and documentation. Let me know if you want to drop on a call to discuss. |
@mattnield - Looks like you got a working update. Looking forward to using this feature on an upcoming project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mattnield!
thanks for the work you have done!
I do love the way you adopted the "architecture" of the plugin. 👍👍👍
Documentation + tests are also included. 🥇
Just one note:
- I would probably make the taxonomy support configurable to allow the users to turn it off
- I am still not decided whether opt-in or opt-out is better for default - what do you think?
- I would love to do the same with
type
summit
We could definitely schedule a call and discuss is.
Hi @Simply007, Thanks 😄 Yes, let's have a call about your suggestion:
If you're free tomorrow afternoon, that could work? We can speak on Slack 🤙 |
Sorry @mattnield to keep you waiting, but there is an issue with schema definition. When we have implemented the schema definition, the empty linked element value became Problem description here: https://github.com/Simply007/gatsby-null-instead-of-array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @mattnield,
finally, we have released the v4.0.0, so I am ready to merge your pull request and release it as the v4.2 (we will skip 4.1 because it is currently used for gatsby preview development and it will be moved to v4.3)
I have left some rebranding tasks to finish (the snapshot update might need to be done after the changes).
Overall it is great! Thanks for your contribution!
src/__tests__/custom-element-resolver/__snapshots__/customElementResolver.spec.js.snap
Outdated
Show resolved
Hide resolved
src/__tests__/linked-items/__snapshots__/circular-reference.spec.js.snap
Outdated
Show resolved
Hide resolved
src/__tests__/linked-items/__snapshots__/simple-resolution.spec.js.snap
Outdated
Show resolved
Hide resolved
src/__tests__/richtext-resolution/__snapshots__/circular-reference.spec.js.snap
Outdated
Show resolved
Hide resolved
src/__tests__/richtext-resolution/__snapshots__/type-resolvers.spec.js.snap
Outdated
Show resolved
Hide resolved
…entResolver.spec.js.snap Co-Authored-By: Ondřej Chrastina <9218736+Simply007@users.noreply.github.com>
…c.js.snap Co-Authored-By: Ondřej Chrastina <9218736+Simply007@users.noreply.github.com>
….spec.js.snap Co-Authored-By: Ondřej Chrastina <9218736+Simply007@users.noreply.github.com>
Co-Authored-By: Ondřej Chrastina <9218736+Simply007@users.noreply.github.com>
Co-Authored-By: Ondřej Chrastina <9218736+Simply007@users.noreply.github.com>
Co-Authored-By: Ondřej Chrastina <9218736+Simply007@users.noreply.github.com>
Co-Authored-By: Ondřej Chrastina <9218736+Simply007@users.noreply.github.com>
…ence.spec.js.snap Co-Authored-By: Ondřej Chrastina <9218736+Simply007@users.noreply.github.com>
…ec.js.snap Co-Authored-By: Ondřej Chrastina <9218736+Simply007@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Simply007. These are in and passing now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THX!
Hello @NathanDCox. I've just sent you an invitation to the Kentico GitHub organization. If you accept it, you'll be able to interact with other Kentico GitHub community members in out Global collaborators dicsussions as well as getting the fresh info about Kentico Github activity. |
Motivation
Fixes #1 by adding basic taxonomy support.
Each taxonomy group can be returned as a nested group of taxonomy terms. So running something like this:
will return:
Checklist
How to test
None of the existing automated tests were relevant. All testing was done through use fo the GraphiQL explorer and building basic listings in Gatsby