Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Rename 'OpenTyrian2000' Menu option to 'Setup' #7

Closed
OpenRift412 opened this issue Aug 1, 2022 · 3 comments
Closed

[Suggestion] Rename 'OpenTyrian2000' Menu option to 'Setup' #7

OpenRift412 opened this issue Aug 1, 2022 · 3 comments
Labels
enhancement New feature or request fixed in mainline This bug has been fixed/feature already exists in the mainline repository (opentyrian/opentyrian)

Comments

@OpenRift412
Copy link

This is probably just an OCD thing, but it just seems a little weird to have the OpenTyrian-specific settings just labelled as 'OpenTyrian2000' instead of something more informative like 'Settings' or 'Setup'. In my opinion it gives the impression that it's more of just an about screen than a menu with additional settings.

Thoughts?

@KScl KScl added enhancement New feature or request fixed in mainline This bug has been fixed/feature already exists in the mainline repository (opentyrian/opentyrian) labels Nov 12, 2023
@KScl
Copy link
Owner

KScl commented Nov 12, 2023

Relevant issue: opentyrian#51

I'm not sure I actually agree with this, as "Setup" doesn't really indicate that options specifically related to OpenTyrian2000 are to be found there. "OT2K Setup" may be better.

@OpenRift412
Copy link
Author

Relevant issue: opentyrian#51

I'm not sure I actually agree with this, as "Setup" doesn't really indicate that options specifically related to OpenTyrian2000 are to be found there. "OT2K Setup" may be better.

Well the jukebox is also located there, so I think a more agnostic name would still be appropriate.

@KScl
Copy link
Owner

KScl commented Feb 18, 2024

Fixed by 132e8b4.

@KScl KScl closed this as completed Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in mainline This bug has been fixed/feature already exists in the mainline repository (opentyrian/opentyrian)
Projects
None yet
Development

No branches or pull requests

2 participants