Fixing an issue where TestData was not properly reset between different test runs, so tests accidentally passed due to uncleared state of test before

Author: JustoSenka

RobotRuntime/Execution/Runners/NestedCommandRunner.cs

@@ -55,9 +55,6 @@ public void Run(IRunnable runnable)
                 TestData.ShouldFailTest = true;
                 return;
             }
-
-            if (TestData.ShouldPassTest)
-                return;
         }
 
 

RobotRuntime/MouseRobot/TestRunner.cs

@@ -54,8 +54,7 @@ public void LoadSettings()
         private void InitializeNewRun()
         {
             TestRunStart?.Invoke();
-            TestData.ShouldCancelRun = false;
-            TestData.ShouldFailTest = false;
+            ResetTestData(TestData);
 
             AssetGuidManager.LoadMetaFiles();
             RuntimeAssetManager.CollectAllImporters();
@@ -77,6 +76,7 @@ public Task StartRecording(LightRecording lightRecording)
         {
             InitializeNewRun();
 
+            ResetTestData(TestData);
             TestData.TestFixture = lightRecording;
             RunnerFactory.PassDependencies(TestData);
 
@@ -91,6 +91,13 @@ public Task StartRecording(LightRecording lightRecording)
             });
         }
 
+        private void ResetTestData(TestData testData)
+        {
+            testData.ShouldPassTest = false;
+            testData.ShouldFailTest = false;
+            testData.ShouldCancelRun = false;
+        }
+
         /// <summary>
         /// Runs all tests from all test fixtures.
         /// Accepts Regex filter for fixture and test names.
@@ -131,6 +138,8 @@ await Task.Run(() =>
 
                     foreach (var test in fixture.Tests)
                     {
+                        ResetTestData(TestData);
+
                         var testMathesFilter = Regex.IsMatch(fixture.Name + "." + test.Name, testFilter, RegexOptions.IgnoreCase);
                         if (!fixtureMathesFilter && !testMathesFilter)
                             continue;