Latest patch breaking?

[ablaom]

I suspect the latest patch adding pairwise is breaking. For example, Clustering.jl is now failing tests:

(@temp) pkg> test Clustering
     Testing Clustering
      Status `/private/var/folders/4n/gvbmlhdc8xj973001s6vdyw00000gq/T/jl_L9CCNk/Project.toml`
  [aaaa29a8] Clustering v0.14.2
  [944b1d66] CodecZlib v0.7.0
  [b4f34e82] Distances v0.10.2
  [b8a86587] NearestNeighbors v0.4.8
  [2913bbd2] StatsBase v0.33.8
  [8bb1440f] DelimitedFiles `@stdlib/DelimitedFiles`
  [37e2e46d] LinearAlgebra `@stdlib/LinearAlgebra`
  [de0858da] Printf `@stdlib/Printf`
  [9a3f8284] Random `@stdlib/Random`
  [2f01184e] SparseArrays `@stdlib/SparseArrays`
  [10745b16] Statistics `@stdlib/Statistics`
  [8dfed614] Test `@stdlib/Test`
      Status `/private/var/folders/4n/gvbmlhdc8xj973001s6vdyw00000gq/T/jl_L9CCNk/Manifest.toml`
  [aaaa29a8] Clustering v0.14.2
  [944b1d66] CodecZlib v0.7.0
  [34da2185] Compat v3.27.0
  [9a962f9c] DataAPI v1.6.0
  [864edb3b] DataStructures v0.18.9
  [b4f34e82] Distances v0.10.2
  [e1d29d7a] Missings v0.4.5
  [b8a86587] NearestNeighbors v0.4.8
  [bac558e1] OrderedCollections v1.4.0
  [a2af1166] SortingAlgorithms v1.0.0
  [90137ffa] StaticArrays v1.1.2
  [82ae8749] StatsAPI v1.0.0
  [2913bbd2] StatsBase v0.33.8
  [3bb67fe8] TranscodingStreams v0.9.5
  [0dad84c5] ArgTools `@stdlib/ArgTools`
  [56f22d72] Artifacts `@stdlib/Artifacts`
  [2a0f44e3] Base64 `@stdlib/Base64`
  [ade2ca70] Dates `@stdlib/Dates`
  [8bb1440f] DelimitedFiles `@stdlib/DelimitedFiles`
  [8ba89e20] Distributed `@stdlib/Distributed`
  [f43a241f] Downloads `@stdlib/Downloads`
  [b77e0a4c] InteractiveUtils `@stdlib/InteractiveUtils`
  [b27032c2] LibCURL `@stdlib/LibCURL`
  [76f85450] LibGit2 `@stdlib/LibGit2`
  [8f399da3] Libdl `@stdlib/Libdl`
  [37e2e46d] LinearAlgebra `@stdlib/LinearAlgebra`
  [56ddb016] Logging `@stdlib/Logging`
  [d6f4376e] Markdown `@stdlib/Markdown`
  [a63ad114] Mmap `@stdlib/Mmap`
  [ca575930] NetworkOptions `@stdlib/NetworkOptions`
  [44cfe95a] Pkg `@stdlib/Pkg`
  [de0858da] Printf `@stdlib/Printf`
  [3fa0cd96] REPL `@stdlib/REPL`
  [9a3f8284] Random `@stdlib/Random`
  [ea8e919c] SHA `@stdlib/SHA`
  [9e88b42a] Serialization `@stdlib/Serialization`
  [1a1011a3] SharedArrays `@stdlib/SharedArrays`
  [6462fe0b] Sockets `@stdlib/Sockets`
  [2f01184e] SparseArrays `@stdlib/SparseArrays`
  [10745b16] Statistics `@stdlib/Statistics`
  [fa267f1f] TOML `@stdlib/TOML`
  [a4e569a6] Tar `@stdlib/Tar`
  [8dfed614] Test `@stdlib/Test`
  [cf7118a7] UUIDs `@stdlib/UUIDs`
  [4ec0a83e] Unicode `@stdlib/Unicode`
  [deac9b47] LibCURL_jll `@stdlib/LibCURL_jll`
  [29816b5a] LibSSH2_jll `@stdlib/LibSSH2_jll`
  [c8ffd9c3] MbedTLS_jll `@stdlib/MbedTLS_jll`
  [14a3606d] MozillaCACerts_jll `@stdlib/MozillaCACerts_jll`
  [83775a58] Zlib_jll `@stdlib/Zlib_jll`
  [8e850ede] nghttp2_jll `@stdlib/nghttp2_jll`
  [3f19e933] p7zip_jll `@stdlib/p7zip_jll`
     Testing Running tests...
Runing tests:
* seeding.jl ...
WARNING: both StatsBase and Distances export "pairwise"; uses of it in module Clustering must be qualified
Seeds number check for KmCentralityAlg: Test Failed at /Users/anthony/.julia/packages/Clustering/tt9vc/test/seeding.jl:56
  Expression: initseeds(alg, X, 0)
    Expected: ArgumentError
      Thrown: UndefVarError
Stacktrace:
 [1] macro expansion
   @ ~/.julia/packages/Clustering/tt9vc/test/seeding.jl:56 [inlined]
 [2] macro expansion
   @ /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1226 [inlined]
 [3] macro expansion
   @ ~/.julia/packages/Clustering/tt9vc/test/seeding.jl:54 [inlined]
 [4] macro expansion
   @ /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
 [5] macro expansion
   @ ~/.julia/packages/Clustering/tt9vc/test/seeding.jl:40 [inlined]
 [6] macro expansion
   @ /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
 [7] top-level scope
   @ ~/.julia/packages/Clustering/tt9vc/test/seeding.jl:7
Seeds number check for KmCentralityAlg: Test Failed at /Users/anthony/.julia/packages/Clustering/tt9vc/test/seeding.jl:57
  Expression: initseeds(alg, X, n + 1)
    Expected: ArgumentError
      Thrown: UndefVarError

[andreasnoack]

Yeah. New exports can be breaking. We should probably make a release-0.33 branch where we revert the commit and make a 0.33.9 release and then a 0.34 release from master.

[nalimilan]

That's unfortunate but a necessary evil IMHO. I don't think we should tag a new breaking release. If StatsBase had reached 1.0, we wouldn't tag 2.0 because of a new export, just like Julia adds new exports in non-breaking release. I think the solution is to update Clustering ASAP and tag a new release there.

[nalimilan]

Actually all that's needed is a tagging a new Distances release, since I had already merged a PR to fix the problem. This will also fix Clustering.jl tests (AFAICT it's only the testing code that broke, not the package code). See JuliaStats/Distances.jl#218.

[nalimilan]

Fixed by JuliaRegistries/General#35908.