Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid repeating first objective evaluation in fit! #637

Merged
merged 4 commits into from
Aug 29, 2022
Merged

Avoid repeating first objective evaluation in fit! #637

merged 4 commits into from
Aug 29, 2022

Conversation

dmbates
Copy link
Collaborator

@dmbates dmbates commented Aug 26, 2022

  • Modify the obj function in fit! for a LinearMixedModel to return the previously calculated optsum.finitial when isone(iter += 1)

Did behavior change? Did you add new features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

dmbates and others added 2 commits August 26, 2022 17:26
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dmbates dmbates requested a review from palday August 26, 2022 22:29
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Base: 94.21% // Head: 94.17% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (f21e84b) compared to base (73ad7f1).
Patch coverage: 91.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   94.21%   94.17%   -0.04%     
==========================================
  Files          29       29              
  Lines        2765     2766       +1     
==========================================
  Hits         2605     2605              
- Misses        160      161       +1     
Impacted Files Coverage Δ
src/linearmixedmodel.jl 98.09% <91.66%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@palday palday merged commit 04c2724 into main Aug 29, 2022
@palday palday deleted the iter0 branch August 29, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants