Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Tuple{Bool, Bool} for xtrimspine and ytrimspine. #2171

Closed
wants to merge 5 commits into from
Closed

Allow Tuple{Bool, Bool} for xtrimspine and ytrimspine. #2171

wants to merge 5 commits into from

Conversation

marcpabst
Copy link

Description

Fixes #2169

Allows to pass both a Bool and a Tuple{Bool, Bool} for xtrimspine and ytrimspine.

Type of change

Delete options that do not apply:

  • New feature (non-breaking change which adds functionality)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

asinghvi17
asinghvi17 reviewed Jul 23, 2022
View reviewed changes
@marcpabst
Copy link
Author

Can someone point me to how I would implement a test for this?

jkrumbiegel
jkrumbiegel approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@jkrumbiegel jkrumbiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. For a test, have a look at how the other visual reference tests are implemented and just make a similar one where you have each combination of trims in a couple Axes in a GridLayout. Make the spine width thick so the visual differ would pick up on any changes.

@jkrumbiegel
Copy link
Member

I'll add a test so we can get this merged

@jkrumbiegel jkrumbiegel mentioned this pull request Sep 16, 2022
Merged
7 tasks
@jkrumbiegel
Copy link
Member

Closed in favor of #2279

jkrumbiegel added a commit that referenced this pull request Sep 16, 2022
@jkrumbiegel @SimonDanisch
Continuation of #2171 trimspines (#2279)
f58adba 
* Allow Tuple{Bool, Bool} for xtrimspine and ytrimspine.

* add entry to NEWS.md

* Update NEWS.md

* add test and fix reversed axis case

Co-authored-by: Marc Pabst <github@marcpabst.com>
Co-authored-by: Simon <sdanisch@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asinghvi17 asinghvi17 asinghvi17 left review comments

@SimonDanisch SimonDanisch SimonDanisch approved these changes

@jkrumbiegel jkrumbiegel jkrumbiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support both "Bool" and "Tuple{Bool, Bool}" for "xtrimspine" and "ytrimspine"
4 participants
@marcpabst @jkrumbiegel @SimonDanisch @asinghvi17