Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification time of unchanged files are changed #827

Closed
dundargoc opened this issue Dec 4, 2023 · 1 comment · Fixed by #836
Closed

Modification time of unchanged files are changed #827

dundargoc opened this issue Dec 4, 2023 · 1 comment · Fixed by #836
Labels
bug Something isn't working

Comments

@dundargoc
Copy link
Contributor

Hello. I noticed that the modification time of files that are "unchanged" are still changed. This causes our buildsystem to always run stylua even when it's not needed, since it uses modification time to determine whether a file has been changed or not. I would like to make the feature request to only change modification time if the file is actually changed and not otherwise. Thank you for your time!

Inpsired by this PR: neovim/neovim#26393

@JohnnyMorganz JohnnyMorganz added the enhancement New feature or request label Dec 5, 2023
@alerque
Copy link
Contributor

alerque commented Dec 12, 2023

I agree this is a bug and should be fixed.

In the mean time you might be interested in a utility I wrote git-warp-time that can be used in build systems or Git hooks or CI or anywhere else to keep timestamp based build systems from rebuilding things that haven't actually been modified.

@JohnnyMorganz JohnnyMorganz added bug Something isn't working and removed enhancement New feature or request labels Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants