Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for long double #30

Merged
merged 2 commits into from
Nov 28, 2021
Merged

Conversation

GuillaumeGomez
Copy link
Contributor

Needed for rust-lang/libc#2565.

@GuillaumeGomez
Copy link
Contributor Author

ping @JohnTitor

@JohnTitor
Copy link
Owner

Looks fine, could you also add a test case here? https://github.com/JohnTitor/ctest2/tree/master/testcrate/src

@GuillaumeGomez
Copy link
Contributor Author

From what I can read, it's supposed to compare the rust equivalent, however long double has no equivalent in Rust. So: how can I add a test for a type which doesn't exist in rust?

@JohnTitor
Copy link
Owner

I wanted to ensure that it works fine by replicating code from the above libc PR, doesn't it make much sense? If not, I'm fine to merge as-is.

@GuillaumeGomez
Copy link
Contributor Author

I can give it a try at least.

@GuillaumeGomez
Copy link
Contributor Author

Let's see how it goes now. :3

@GuillaumeGomez GuillaumeGomez force-pushed the long-double branch 16 times, most recently from 829797b to ec4aa50 Compare November 28, 2021 15:30
@GuillaumeGomez
Copy link
Contributor Author

@JohnTitor Does the test looks ok to you?

Copy link
Owner

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thanks a lot!

@JohnTitor JohnTitor merged commit 1769ea1 into JohnTitor:master Nov 28, 2021
@GuillaumeGomez GuillaumeGomez deleted the long-double branch November 28, 2021 18:15
@GuillaumeGomez
Copy link
Contributor Author

Thanks for the release! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants