Skip to content

Commit f189d8c

Browse files
authored
RG-2473 don't unmount react root because it can be reused later (#7656)
minor: log auth error
1 parent 708b012 commit f189d8c

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/header/smart-profile.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ export default class SmartProfile extends PureComponent<SmartProfileProps, Smart
5656
try {
5757
await this.props.auth.login();
5858
} catch (err) {
59-
// do nothing
59+
// eslint-disable-next-line no-console
60+
console.debug('Profile login errored', err);
6061
} finally {
6162
this.setState({loading: false});
6263
}

src/login-dialog/service.tsx

+4-1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ export default function showAuthDialog(props: LoginDialogAttrs = {onCancel: noop
2828
});
2929

3030
return () => {
31-
reactRoot.unmount();
31+
renderLoginDialog({
32+
...props,
33+
show: false
34+
});
3235
};
3336
}

0 commit comments

Comments
 (0)