Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core suggests irrelevant firmware as the default #183

Closed
5 of 11 tasks
JesseTG opened this issue Feb 22, 2024 · 4 comments
Closed
5 of 11 tasks

Core suggests irrelevant firmware as the default #183

JesseTG opened this issue Feb 22, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@JesseTG
Copy link
Owner

JesseTG commented Feb 22, 2024

What version of melonDS DS are you using?

1.0.3

Does the problem happen in standalone melonDS?

No, it's a bug specific to melonDS DS.

What happened?

melonDS DS somehow selected a PC-88 BIOS file as a default for the DS firmware. The Nintendo DS cannot run PC-88 code. Followed up from #177

What should've happened instead?

The PC-88 BIOS image should not be listed in the core options.

Which platforms do you see the problem on?

  • Windows
  • macOS
  • Linux
  • Android
  • iOS
  • tvOS
  • Other (specify below)

Which versions of the OS?

10

Which libretro frontend are you using?

RALibretro 1.7.0

Terms

  • I agree to follow the code of conduct.
  • I understand that melonDS DS is not developed or maintained by the authors of melonDS.
  • I understand that this form is for reporting bugs, not for requesting help.
  • I understand that the author develops this core in his spare time, and that he is under no obligation to respond to this bug report.
@JesseTG JesseTG added the bug Something isn't working label Feb 22, 2024
@JesseTG
Copy link
Owner Author

JesseTG commented Feb 22, 2024

@ladynadiad, could you tell me something? The PC-88 BIOS file you used...can it be modified by the respective emulator, like how the DS firmware itself can change (e.g. due to user settings)? Or is it intended to be read-only?

@ladynadiad
Copy link

As far as I know it cannot, not even in the standalone. Computer based systems like that do require that files cannot be modified in a way that could potentially allow for cheating or RA would not even support them. To be honest, not a lot of systems do allow BIOS to be modified, but I do know PC-88 has a few BIOS sets floating around which makes it a real pain to support, but I think that is more due to the fact that the system has a few different models out there rather than anything being modified. But looking at those files, none have been modified since 2022.

@JesseTG
Copy link
Owner Author

JesseTG commented Jul 9, 2024

I'm going to submit a PR upstream to validate -- but not modify -- the checksum of a firmware blob. That should resolve this issue once and for all.

@JesseTG JesseTG added the needs upstream patch This ticket requires a specific change in the original melonDS codebase. label Jul 9, 2024
@JesseTG
Copy link
Owner Author

JesseTG commented Jul 15, 2024

Hm, that's more complicated than I expected.

I'll just check the firmware identifier; if this issue crops up again, then I'll look into complete validation.

@JesseTG JesseTG removed the needs upstream patch This ticket requires a specific change in the original melonDS codebase. label Jul 15, 2024
@JesseTG JesseTG unpinned this issue Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants