Make easier re enable usercomment #11249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| entryEditorPreferences.setShowUserCommentsFields(false); | ||
| setupPanel(entry, false); | ||
| Button toggleCommentsButton = new Button("Hide user comments"); |
There was a problem hiding this comment.
You might want to use a toggleButton here since there are two possible states for the button: Show or Hide comments.
| Button toggleCommentsButton = new Button("Hide user comments"); | ||
| toggleCommentsButton.setOnAction(e -> { | ||
| if (gridPane.getChildren().contains(fieldEditorForUserDefinedComment.get().getNode())) { | ||
| gridPane.getChildren().remove(fieldEditorForUserDefinedComment.get().getNode()); |
There was a problem hiding this comment.
You don't have to remove the node from the layout, just setVisible(false).
|
Hi @sirine707, what is the status here? I see that the some tests are failing and the PR is still a draft. |
|
hello @calixtus , I dont have plans to continue working on this PR , thanks for your understanding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11021
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)