-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace unittests with pytests + update CI workflow and code doc-strings #177
Conversation
Hi @JaGeo, this PR is could be reviewed and merged. |
I think probably test durations file is the issue. I need to update it seems |
Try changing ubuntu version as per actions/runner-images#6709
…/LobsterPy into replace_unittest_with_pytest remote sync
Hi @JaGeo , It would be best for me if you can review and merge this PR before others. I can then get started with updating the readme and other stuff 😄 |
Also, workflow I used for deploying docs to gh-pages is from the following link So only thing we need to more is enable github pages for the Lobsterpy repo as it is stated in Step 4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remarked some style issues for the comments. Otherwise, it looks good.
I found a few lines that aren't covered yet by tests (cli.py). Maybe, this can be addressed as another PR. |
Hi @JaGeo , I think this PR could be merged now. I Will resolve other minor merge conflicts that will arise in other PR when I get some time later. |
Also, please enable GitHub pages for the LobsterPy repo. Before merging this PR. |
Closes #97, #108, #126, #144, #164 and #166
Changes