Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unittests with pytests + update CI workflow and code doc-strings #177

Merged
merged 50 commits into from
Nov 8, 2023

Conversation

naik-aakash
Copy link
Collaborator

@naik-aakash naik-aakash commented Oct 27, 2023

Closes #97, #108, #126, #144, #164 and #166

Changes

  • All tests have moved out of core package into tests
  • Used pytestify to convert all our unittests to pytests
  • Refactor tests to use fixures mainly for testing analyze ,describe and plotting modules (results in faster test execution with minimal use of resources)
  • Updated pre-commit config
  • Excluded tests from coverage reports
  • Updated doc building config files to exclude tests
  • Add missing type hints in modules
  • Update test durations file
  • Fix pre-commit config file
  • Include pre-commit as part of workflow
  • Add tests for doc-building
  • Add doc-deployment to github pages workflow (Will remove our dependency on read the docs , I am not able to check it myself as it is supposed to be run on master branch, needs to be tested)

@naik-aakash
Copy link
Collaborator Author

Hi @JaGeo, this PR is could be reviewed and merged.

@naik-aakash
Copy link
Collaborator Author

I think probably test durations file is the issue. I need to update it seems

@naik-aakash naik-aakash changed the title Replace unittest with pytest [WIP] Replace unittest with pytest Oct 27, 2023
@naik-aakash naik-aakash changed the title [WIP] Replace unittests with pytests Replace unittests with pytests Oct 29, 2023
@naik-aakash naik-aakash changed the title Replace unittests with pytests Replace unittests with pytests + update CI workflow and code doc-strings Oct 29, 2023
@naik-aakash
Copy link
Collaborator Author

Hi @JaGeo , It would be best for me if you can review and merge this PR before others. I can then get started with updating the readme and other stuff 😄

@naik-aakash
Copy link
Collaborator Author

naik-aakash commented Oct 30, 2023

Also, workflow I used for deploying docs to gh-pages is from the following link
https://coderefinery.github.io/documentation/gh_workflow/ and a bit of atomate2 docs workflow.

So only thing we need to more is enable github pages for the Lobsterpy repo as it is stated in Step 4.

Copy link
Owner

@JaGeo JaGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remarked some style issues for the comments. Otherwise, it looks good.

@JaGeo
Copy link
Owner

JaGeo commented Nov 6, 2023

I found a few lines that aren't covered yet by tests (cli.py). Maybe, this can be addressed as another PR.

@naik-aakash
Copy link
Collaborator Author

Hi @JaGeo , I think this PR could be merged now.

I Will resolve other minor merge conflicts that will arise in other PR when I get some time later.

@naik-aakash
Copy link
Collaborator Author

Also, please enable GitHub pages for the LobsterPy repo. Before merging this PR.

@JaGeo JaGeo merged commit 0783966 into JaGeo:main Nov 8, 2023
@naik-aakash naik-aakash deleted the replace_unittest_with_pytest branch June 20, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test speed-up
2 participants