Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage cli.py #181

Closed
JaGeo opened this issue Nov 6, 2023 · 1 comment · Fixed by #185
Closed

Increase test coverage cli.py #181

JaGeo opened this issue Nov 6, 2023 · 1 comment · Fixed by #185

Comments

@JaGeo
Copy link
Owner

JaGeo commented Nov 6, 2023

There are a few lines in the cli.py that are not yet covered by tests including

        if args.addtotaldos:
            dos_plotter.add_dos(dos=lobs_dos, label="Total DOS")

)
Maybe, we could address this.
@naik-aakash
Copy link
Collaborator

Yes, I will try to increase coverage of other modules too where I see we have less than 95% overall coverage

@naik-aakash naik-aakash mentioned this issue Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase test coverage naik-aakash/LobsterPy
2 participants
@JaGeo @naik-aakash