Enums should follow Swift conventions #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

minuscorp opened this issue Nov 1, 2017 · 1 comment

minuscorp commented Nov 1, 2017

This enumerations should be changed from:

public enum Theme {
        case Success(Style)
        case Fail(Style)
        case Info(Style)
        case Warning(Style)
    }

    public enum Style {
        case Light
        case Dark
    }

To:

public enum Theme {
        case success(Style)
        case fail(Style)
        case info(Style)
        case warning(Style)
    }

    public enum Style {
        case light
        case dark
    }

In order to follow the Swift enumeration conventions as accepted in here

Owner

JT501 commented Nov 2, 2017 •

edited

Loading

Thank you for reminding 😄 . I have fixed it in 1.0.1 Release.

JT501 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment