Skip to content

Commit 4888a2a

Browse files
refactor: only log retention when count > 0
1 parent b75c249 commit 4888a2a

File tree

1 file changed

+16
-5
lines changed

1 file changed

+16
-5
lines changed

internal/retention/retention.go

+16-5
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@ func DeleteAttachmentBySize(ctx context.Context, tracer trace.Tracer, fileStore
3838
return 0, err
3939
}
4040

41-
tracer.Trace(ctx, "retention.attachment.size.delete", trace.WithKV("count", count))
41+
if count > 0 {
42+
tracer.Trace(ctx, "retention.attachment.size.delete", trace.WithKV("count", count))
43+
}
4244

4345
return count, nil
4446
}
@@ -64,7 +66,9 @@ func DeleteEnvelopeByCount(ctx context.Context, tracer trace.Tracer, db database
6466
return 0, err
6567
}
6668

67-
tracer.Trace(ctx, "retention.envelope.count.delete", trace.WithKV("count", count))
69+
if count > 0 {
70+
tracer.Trace(ctx, "retention.envelope.count.delete", trace.WithKV("count", count))
71+
}
6872

6973
return count, nil
7074
}
@@ -80,7 +84,9 @@ func DeleteEnvelopeByAge(ctx context.Context, tracer trace.Tracer, db database.Q
8084
return 0, err
8185
}
8286

83-
tracer.Trace(ctx, "retention.envelope.age.delete", trace.WithKV("count", count))
87+
if count > 0 {
88+
tracer.Trace(ctx, "retention.envelope.age.delete", trace.WithKV("count", count))
89+
}
8490

8591
return count, nil
8692
}
@@ -112,7 +118,10 @@ func DeleteOrphanAttachments(ctx context.Context, tracer trace.Tracer, db databa
112118
}
113119
}
114120

115-
tracer.Trace(ctx, "retention.attachment.orphan.delete", trace.WithKV("count", len(atts)))
121+
count := len(atts)
122+
if count > 0 {
123+
tracer.Trace(ctx, "retention.attachment.orphan.delete", trace.WithKV("count", count))
124+
}
116125
}
117126
}
118127

@@ -127,7 +136,9 @@ func DeleteTraceByAge(ctx context.Context, tracer trace.Tracer, db database.Quer
127136
return 0, err
128137
}
129138

130-
tracer.Trace(ctx, "retention.trace.age.delete", trace.WithKV("count", count))
139+
if count > 0 {
140+
tracer.Trace(ctx, "retention.trace.age.delete", trace.WithKV("count", count))
141+
}
131142

132143
return count, nil
133144
}

0 commit comments

Comments
 (0)