Skip to content

Commit 35b4d8e

Browse files
refactor: rename garden to trim
1 parent 23206e5 commit 35b4d8e

File tree

9 files changed

+42
-42
lines changed

9 files changed

+42
-42
lines changed

internal/core/bus.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ type EventEnvelopeDeleted struct {
1212
IDS []int64
1313
}
1414

15-
type EventGardenStart struct {
15+
type EventTrimStart struct {
1616
Response chan<- bool
1717
}
1818

1919
type Bus struct {
2020
Mutex sync.Mutex
2121
EnvelopeCreated []func(cc *Context, evt EventEnvelopeCreated)
2222
EnvelopeDeleted []func(cc *Context, evt EventEnvelopeDeleted)
23-
GardenStart func(cc *Context, evt EventGardenStart)
23+
TrimStart func(cc *Context, evt EventTrimStart)
2424
}
2525

2626
func NewBus() *Bus {

internal/events/envelope.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -30,19 +30,19 @@ func PublishEnvelopeDeleted(cc *core.Context, ids ...int64) {
3030
cc.Bus.Mutex.Unlock()
3131
}
3232

33-
func OnGardenStart(app core.App, fn func(cc *core.Context, evt core.EventGardenStart)) {
33+
func OnTrimStart(app core.App, fn func(cc *core.Context, evt core.EventTrimStart)) {
3434
app.Bus.Mutex.Lock()
35-
if app.Bus.GardenStart != nil {
36-
panic("GardenStart handler is being redefined")
35+
if app.Bus.TrimStart != nil {
36+
panic("TrimStart handler is being redefined")
3737
}
38-
app.Bus.GardenStart = fn
38+
app.Bus.TrimStart = fn
3939
app.Bus.Mutex.Unlock()
4040
}
4141

42-
func PublishGardenStart(cc *core.Context) <-chan bool {
42+
func PublishTrimStart(cc *core.Context) <-chan bool {
4343
res := make(chan bool)
4444
cc.Bus.Mutex.Lock()
45-
cc.Bus.GardenStart(cc, core.EventGardenStart{Response: res})
45+
cc.Bus.TrimStart(cc, core.EventTrimStart{Response: res})
4646
cc.Bus.Mutex.Unlock()
4747
return res
4848
}

internal/procs/gardener.go internal/procs/trimmer.go

+22-22
Original file line numberDiff line numberDiff line change
@@ -13,26 +13,26 @@ import (
1313
"github.com/rs/zerolog/log"
1414
)
1515

16-
func GardenStart(cc *core.Context) error {
16+
func TrimStart(cc *core.Context) error {
1717
ctx := cc.Context()
1818
select {
1919
case <-ctx.Done():
2020
return ctx.Err()
21-
case res := <-events.PublishGardenStart(cc):
21+
case res := <-events.PublishTrimStart(cc):
2222
if res {
2323
return nil
2424
}
2525

26-
return fmt.Errorf("already gardening")
26+
return fmt.Errorf("already trimming")
2727
}
2828
}
2929

30-
func GardenerBackground(ctx context.Context, app core.App, policy models.RetentionPolicy) {
30+
func TrimmerBackground(ctx context.Context, app core.App, policy models.RetentionPolicy) {
3131
envDeletedC := make(chan core.EventEnvelopeDeleted, 1)
3232
envCreatedC := make(chan core.EventEnvelopeCreated, 1)
33-
evtGardenStart := make(chan core.EventGardenStart, 1)
33+
evtTrimStart := make(chan core.EventTrimStart, 1)
3434

35-
go gardener(app.Context(ctx), policy, envCreatedC, envDeletedC, evtGardenStart)
35+
go trimmer(app.Context(ctx), policy, envCreatedC, envDeletedC, evtTrimStart)
3636

3737
events.OnEnvelopeCreated(app, func(cc *core.Context, evt core.EventEnvelopeCreated) {
3838
select {
@@ -58,9 +58,9 @@ func GardenerBackground(ctx context.Context, app core.App, policy models.Retenti
5858
}
5959
})
6060

61-
events.OnGardenStart(app, func(cc *core.Context, evt core.EventGardenStart) {
61+
events.OnTrimStart(app, func(cc *core.Context, evt core.EventTrimStart) {
6262
select {
63-
case evtGardenStart <- evt:
63+
case evtTrimStart <- evt:
6464
default:
6565
select {
6666
case <-ctx.Done():
@@ -71,28 +71,28 @@ func GardenerBackground(ctx context.Context, app core.App, policy models.Retenti
7171
})
7272
}
7373

74-
func gardener(
74+
func trimmer(
7575
cc *core.Context,
7676
policy models.RetentionPolicy,
7777
envCreatedC <-chan core.EventEnvelopeCreated,
7878
envDeletedC <-chan core.EventEnvelopeDeleted,
79-
evtGardenStart <-chan core.EventGardenStart,
79+
evtTrimStart <-chan core.EventTrimStart,
8080
) {
8181
ctx := cc.Context()
8282
ticker := time.NewTicker(30 * time.Minute)
8383

8484
clean := func() {
85-
gardenerDeleteByAge(cc, policy)
86-
gardenerDeleteOrphanAttachments(cc)
85+
trimmerDeleteByAge(cc, policy)
86+
trimmerDeleteOrphanAttachments(cc)
8787

8888
storage, err := StorageGet(cc)
8989
if err != nil {
9090
log.Err(err).Msg("Failed to get storage")
9191
return
9292
}
9393

94-
gardenerDeleteByEnvelopeCount(cc, policy, storage)
95-
gardenerDeleteByAttachmentSize(cc, policy, storage)
94+
trimmerDeleteByEnvelopeCount(cc, policy, storage)
95+
trimmerDeleteByAttachmentSize(cc, policy, storage)
9696
}
9797
clean()
9898

@@ -107,13 +107,13 @@ func gardener(
107107
continue
108108
}
109109

110-
gardenerDeleteByEnvelopeCount(cc, policy, storage)
111-
gardenerDeleteByAttachmentSize(cc, policy, storage)
110+
trimmerDeleteByEnvelopeCount(cc, policy, storage)
111+
trimmerDeleteByAttachmentSize(cc, policy, storage)
112112
case <-envDeletedC:
113-
gardenerDeleteOrphanAttachments(cc)
113+
trimmerDeleteOrphanAttachments(cc)
114114
case <-ticker.C:
115115
clean()
116-
case evt := <-evtGardenStart:
116+
case evt := <-evtTrimStart:
117117
clean()
118118

119119
select {
@@ -124,7 +124,7 @@ func gardener(
124124
}
125125
}
126126
}
127-
func gardenerDeleteByAttachmentSize(cc *core.Context, policy models.RetentionPolicy, storage models.Storage) {
127+
func trimmerDeleteByAttachmentSize(cc *core.Context, policy models.RetentionPolicy, storage models.Storage) {
128128
if policy.AttachmentSize == nil {
129129
return
130130
}
@@ -140,7 +140,7 @@ func gardenerDeleteByAttachmentSize(cc *core.Context, policy models.RetentionPol
140140
}
141141
}
142142

143-
func gardenerDeleteByEnvelopeCount(cc *core.Context, policy models.RetentionPolicy, storage models.Storage) {
143+
func trimmerDeleteByEnvelopeCount(cc *core.Context, policy models.RetentionPolicy, storage models.Storage) {
144144
if policy.EnvelopeCount == nil {
145145
return
146146
}
@@ -157,7 +157,7 @@ func gardenerDeleteByEnvelopeCount(cc *core.Context, policy models.RetentionPoli
157157
}
158158
}
159159

160-
func gardenerDeleteByAge(cc *core.Context, policy models.RetentionPolicy) {
160+
func trimmerDeleteByAge(cc *core.Context, policy models.RetentionPolicy) {
161161
if policy.EnvelopeAge == nil {
162162
return
163163
}
@@ -171,7 +171,7 @@ func gardenerDeleteByAge(cc *core.Context, policy models.RetentionPolicy) {
171171
}
172172
}
173173

174-
func gardenerDeleteOrphanAttachments(cc *core.Context) {
174+
func trimmerDeleteOrphanAttachments(cc *core.Context) {
175175
for {
176176
atts, err := db.EnvelopeAttachmentListOrphan(cc, 10)
177177
if err != nil {

internal/procs/vacuum.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88
"github.com/rs/zerolog/log"
99
)
1010

11-
func VacuumStart(ctx context.Context, app core.App) {
11+
func VacuumBackground(ctx context.Context, app core.App) {
1212
go vacuum(app.Context(ctx))
1313
}
1414

main.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ func run(ctx context.Context, shutdown context.CancelFunc, cli config.CLI) <-cha
6262
}
6363

6464
procs.MailmanBackground(ctx, app)
65-
procs.GardenerBackground(ctx, app, cfg.RetentionPolicy)
66-
procs.VacuumStart(ctx, app)
65+
procs.TrimmerBackground(ctx, app, cfg.RetentionPolicy)
66+
procs.VacuumBackground(ctx, app)
6767

6868
var backgrounds []background.Background
6969

web/controllers/controllers.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -75,14 +75,14 @@ func Vacuum(c *fiber.Ctx, cc *core.Context) error {
7575
return c.SendStatus(http.StatusNoContent)
7676
}
7777

78-
func Garden(c *fiber.Ctx, cc *core.Context) error {
78+
func Trim(c *fiber.Ctx, cc *core.Context) error {
7979
// Execute
80-
err := procs.GardenStart(cc)
80+
err := procs.TrimStart(cc)
8181
if err != nil {
8282
return helpers.Error(c, err)
8383
}
8484

8585
// Response
86-
c.Set("HX-Trigger", "garden")
86+
c.Set("HX-Trigger", "trim")
8787
return c.SendStatus(http.StatusNoContent)
8888
}

web/http/routes.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func routes(http *fiber.App, app core.App, retentionPolicy models.RetentionPolic
4343

4444
http.Post("/send", middleware.App(app, controllers.Send))
4545
http.Post("/vacuum", middleware.App(app, controllers.Vacuum))
46-
http.Post("/garden", middleware.App(app, controllers.Garden))
46+
http.Post("/trim", middleware.App(app, controllers.Trim))
4747
http.Group("/files", controllers.Files(app))
4848

4949
http.Route("/p", func(http fiber.Router) {

web/views/index.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@ <h2>Storage</h2>
1616
title="Rebuild database file to take the minimal amount of disk space.">
1717
Vacuum Database
1818
</button>
19-
<button hx-delete="/envelopes" data-loading-path="/vacuum" data-loading-disable data-loading-aria-busy
19+
<button hx-post="/trim" data-loading-path="/trim" data-loading-disable data-loading-aria-busy>
20+
Trim Data
21+
</button>
22+
<button hx-delete="/envelopes" data-loading-path="/envelopes" data-loading-disable data-loading-aria-busy
2023
hx-confirm="Are you sure you wish to delete all envelopes?" class="contrast">
2124
Delete Envelopes
2225
</button>
@@ -53,9 +56,6 @@ <h2>Retention Policy</h2>
5356
</tbody>
5457
</table>
5558
</figure>
56-
<button hx-post="/garden" data-loading-path="/garden" data-loading-disable data-loading-aria-busy>
57-
Garden Data
58-
</button>
5959
</article>
6060

6161
<article>

web/views/p/storage-table.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<table hx-trigger="every 5s, databaseVacuum from:body, garden from:body, deleteEnvelopes from:body"
1+
<table hx-trigger="every 5s, databaseVacuum from:body, trim from:body, deleteEnvelopes from:body"
22
hx-get="/p/storage-table" hx-swap="outerHTML">
33
<tbody>
44
<tr>

0 commit comments

Comments
 (0)