Fix preferences for AI

[koppor]

• (1) I did not enter any API token for Hugging face - the field should be empty then? --> Each API provider has a different token - thus, this field should be dependend on the provider
• (2) Rename to "Enable customizing expert settings" - The current text is a bit misleading, because choosing an "AI provider" is also an "AI setting" IMHO, which one customized
• If I change the API entpoint of misral, change back to OpenAI above and change back, my new value is lost - some old value is displayed

Dialog does not store misral URL

"Save"

Open again - OK

Change to "OpenAI"

Change back to "Misral"

Old URL there:

[ThiloteE]

• (2)

  "Enable customizing expert settings"

  This is not good English. "Use custom settings" would be better. Or alternatively "Customize expert settings" or "Enable custom settings". I asked a native US-English speaker.

• (4)

  "These parameters affect how AI will answer your questions" --> rename to --> "These parameters affect how the AI will answer your questions."

[InAnYan]

For the third point: What is the best way to do this?

The situation is: a user has filled a custom API endpoint, but then they switch to other AI provider.

I see there two options:

1. [Current option] We replace custom values with default ones every time the AI provider is switched

Rationale: what if users switches provider, but forgets to change the API URL?

2. For each of the provider, store their custom API URL. <------------- should this be chosen?

[InAnYan]

This also concerns API token:

Should it be custom for every type of AI provider, or any time we change AI provider it becomes empty?

[koppor]

I run now - commit e1a895bf9f4b6a3ebdc362735a7ec2d1e7b2c1b9

• From Thilo (Fix preferences for AI #98 (comment)), "Customize AI settings" still has to be renamed to "Customize expert settings"
• From Thilo (Fix preferences for AI #98 (comment)), the is still missing

[koppor]

Rationale: what if users switches provider, but forgets to change the API URL?

For that, we have "Reset expert settings to default". -- The best would be to have a reset button after the API-base URL to only reset that.

[koppor]

2. For each of the provider, store their custom API URL. <------------- should this be chosen?

Yes.

We also need to work on the hiearchical display. Mac OS finder uses columsn for that:

In JabRef, we use indent.

• Thus, "Chat model" and "API token" should have an indent"

---

I know that for "API base URL" and "Embedding model" this is currently hard.

I assume the user does not need to change the embedding model often? Although, this statement contradicts: #85

Maybe, "Embedding model" needs to be moved to "General" - as the user also can change the "Chat model"?

[koppor]

• I reset JabRef's preferences. Why is there an API token in "OpenAI"

Update This is, how JabRef's reset preferences works...

[koppor]

• There should be a help for "Chat model", too. -- The most hard thing (in the "easy" prefrences) is not documented 🤣🤣

(Also, the dialog would look better, because always (?) at the right side - and not disturbed by one dropdown)

[koppor]

Should it be custom for every type of AI provider,

Yes.

Reason: It is very likely that I as user try more than one AI provider and fetch API keys for that. I want to switch back and forth of these providers easily.

or any time we change AI provider it becomes empty?

No.

(Furthermore, the API key of one provider should not be shared with another provider. I think, the API key exchange is not protected similar to password exchange, but sent directly to the API provider. Thus, if I use a medium-secure AI provider, my key could get compromised by them)

[InAnYan]

Okay, I see, then for each AI provider we need to store:

• Selected chat model
• API token
• API base URL

This will be an interesting challenge 😄, though it shouldn't be too hard

[InAnYan]

#98 (comment)

These points should be fixed in 637d14e

[koppor]

Reply by OpenAPI if Misral key is used:

401 - message: Incorrect API key provided: dWkr3jyb********************UEyx. You can find your API key at https://platform.openai.com/account/api-keys., type: invalid_request_error, param: null, code: invalid_api_key

[koppor]

#98 (comment)

These points should be fixed in 637d14e

Wrong commit link, but the two poitns are fixed

(The others are still open)

[InAnYan]

Okay, I've tried to fix this issue in recent commits...

Should (?) work

[koppor]

No.

[InAnYan]

Fixed

[koppor]

No

[koppor]

547da5d

[koppor]

Tried again with a preference reset. Keeps not working.

[InAnYan]

It's stored, but not used when you send messages.

When user turns off "customize expert settings", should they be resetted?

What if I want to customize expert settings, then turn off, then return to previous parameters that I set?

[koppor]

First of all, please try to follow me slowly. Take the time to understand.

1. First - Customize export settings are turned off
2. Second - "WHAT-THE-FUCK" is a String contained in the URL
3. Third - The AI Returns a 404, because "WHAT THE FUCK" appears in the URL

That must not happen. If the customized expoert settings are disabled, ther normal API url needs to be used

1. Open Preferences
2. Enable Custom expert settings
3. Add „WHAT THE FUCK“ to the URL
4. Save
5. Open Preferences
6. Disable Custom expert settings
7. Open “AI Summary” tab
8. Click on regenerate

[koppor]

When user turns off "customize expert settings", should they be resetted?

No.

What if I want to customize expert settings, then turn off, then return to previous parameters that I set?

Currently, the preference UI renders well to the user. It just does not route the setting properly to the AI code.

[InAnYan]

Okay, sorry, it should be fixed now :)

Just a small change about listening to preferences change

[koppor]

Tried. Works.