Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change size to "about 400 MB" #143

Closed
koppor opened this issue Aug 12, 2024 · 4 comments
Closed

Change size to "about 400 MB" #143

koppor opened this issue Aug 12, 2024 · 4 comments
Milestone

Comments

@koppor
Copy link
Collaborator

koppor commented Aug 12, 2024

Do you have an idea how often the size will change?

Are there code comments pointing to the places in the code if DJL changes the default embedding model?

I think, "382" is a too fine-grained number. Remember, all texts need to be translated. And JabRef translators are lazy ^^.

image

I would propose to use "about 400 MB"

@koppor koppor added this to the Week 1 milestone Aug 12, 2024
@InAnYan
Copy link
Owner

InAnYan commented Aug 12, 2024

Size won't change at all.

It depends on the selected embedding model.

Size may vary a lot, so I use FileUtils.byteCountToDisplaySize. Is there an internationalized method like that?

@InAnYan
Copy link
Owner

InAnYan commented Aug 12, 2024

Size text is not translated. In the translation message there is %0, which I replace with the results of FileUtils.byteCountToDisplaySize

@InAnYan
Copy link
Owner

InAnYan commented Aug 12, 2024

If a translated variant is still needed, then I can code "nicer" solution (like in #145), with "less than 50 MB", "100 MB", etc.

But I like more what we have now:

  1. It's more accurate
  2. MB, GB - I think those terms are heard all over the world and everyone knows them, so maybe this it's not priority (but I'm pretty sure I could be wrong here..)

@koppor
Copy link
Collaborator Author

koppor commented Aug 12, 2024

Thank you for the explanation!

@koppor koppor closed this as not planned Won't fix, can't repro, duplicate, stale Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants