Skip to content

Can SignatureAlgorithm automatically be determined #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpeless opened this issue Mar 14, 2025 · 0 comments
Open

Can SignatureAlgorithm automatically be determined #242

jpeless opened this issue Mar 14, 2025 · 0 comments

Comments

@jpeless
Copy link

jpeless commented Mar 14, 2025

There was an issue (#35) where the request was made about having the SignatureAlgorithm be determined by the contents of the response.

Currently, it appears that the SignatureAlgorithm must be configured to be the same on both the SP and IdP sides. If SP signs with sha1 and then IdP signs with sha256 then validation fails on Unbind calls.

I don't see anything in what I have looked up that says both sides need to use the same algorithm, but the current Saml2Configuration class only allows for setting a single property, so if the config is reused it essentially requires both sides to match.

Would you be open to having a second property that could be used for validating IdP signatures so they could be different (at least, if defined for the IdP then it uses that property, if not, then fall back to the current property)? Any other recommendations? Two configs seems odd if the SignatureAlgorithm is the only property set differently between them.

Otherwise, our customers have less flexibility and need to make sure they are the same when it doesn't appear to be a requirement of SAML.

Appreciate your input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant