Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add are more meaningful message when TSV does not contain correctly named column #64

Closed
matentzn opened this issue Oct 26, 2018 · 3 comments · Fixed by #188
Closed

Add are more meaningful message when TSV does not contain correctly named column #64

matentzn opened this issue Oct 26, 2018 · 3 comments · Fixed by #188

Comments

@matentzn
Copy link

Currently, if a dosdp cannot find a column in the tsv that it expects from the pattern definition, it says:

key not found: biological_process
Exception in thread "main" java.util.NoSuchElementException: key not found: biological_process

To be more user friendly, maybe instead just say:

TSV file does not contain the required column biological_process
@balhoff
Copy link
Member

balhoff commented Jan 17, 2020

Columns will now be optional according to #185. I should add some warning output when the TSV is read if there are missing columns.

@balhoff balhoff added this to the January 2020 release milestone Jan 17, 2020
@matentzn
Copy link
Author

I am slightly worried to make the columns in the vars: section of the dosdp template optional by default; Maybe I am too close to the EQ use case, but dropping the EQ because a column is misnamed that contains a filler variable seems risky. But maybe I am wrong! Would it be easy to create a switch to allow the central variables (those in the vars: section, not data_vars, or data_list_vars) to be required (or better have them required by default and only skip the requirement with that switch parameter)? Or else, make a nice and visible warning whenever a template column is not found in a TSV? What do you think @dosumis

@balhoff
Copy link
Member

balhoff commented Jan 17, 2020

I've implemented "a nice and visible warning" in a PR. It seems like this will help avoid unexpected missing output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants