Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Make dosdp query take a list of patterns as input #120

Closed
matentzn opened this issue Apr 18, 2019 · 5 comments · Fixed by #187
Closed

Feature request: Make dosdp query take a list of patterns as input #120

matentzn opened this issue Apr 18, 2019 · 5 comments · Fixed by #187

Comments

@matentzn
Copy link

Reloading the ontology 100 times to match all uPheno patterns uses too much electricity and takes 1 night :)

@matentzn
Copy link
Author

the batch mode is awesome: Tiny remarks:

  • batchmode variables should be trimmed (twice)
    • --batch-patterns=" pat" breaks (space around vars)
    • --batch-patterns="pat patx" breaks (double space between vars)
  • I would like a progress thing in batchmode that says which pattern it is working on. If I deal with 100ds of patterns (which I do) it looks sad otherwise.

THIS IS AMAZING!

@balhoff
Copy link
Member

balhoff commented Feb 20, 2020

@matentzn I can't replicate your problems with spaces. With this input:

--batch-patterns="hello  there     john  "

I get hello, there, and john.

@matentzn
Copy link
Author

Hmmmm.. thats strange.. In my case DOSDP tried to compile against a pattern named $(PATTERNDIR)/.yaml (which of course did not exist).. running strip and removing the double spaces around the strings fixed it; so I assumed that was the problem.. Strange.

@balhoff
Copy link
Member

balhoff commented Feb 20, 2020

Maybe a Makefile issue?

@matentzn
Copy link
Author

Well, I dont know.

if --batch-patterns="hello there john " does not get you an empty string as well as hello, there and john merge it! In any case, ODK knows what to do. If the problem surfaces again we will just submit a ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants