Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for torch 2.0 #70

Closed
ab3llini opened this issue Oct 4, 2023 · 2 comments · Fixed by #71
Closed

Add support for torch 2.0 #70

ab3llini opened this issue Oct 4, 2023 · 2 comments · Fixed by #71
Assignees
Labels
enhancement New feature or request

Comments

@ab3llini
Copy link

ab3llini commented Oct 4, 2023

Scenario summary

Apple Silicon users cannot run zshot due to torch version being pinned to be strictly less than 2.0 ("torch>=1,<2")

Proposed solution

Update torch to 2.0 and release a new wheel on PyPI 🚀

@ab3llini ab3llini added the enhancement New feature or request label Oct 4, 2023
@ab3llini
Copy link
Author

ab3llini commented Oct 4, 2023

It shouln't really be that hard, I could open a PR if I find some time.

Tips on this => https://towardsdatascience.com/tips-and-tricks-for-upgrading-to-pytorch-2-3127db1d1f3d

@marmg marmg self-assigned this Oct 4, 2023
@marmg
Copy link
Collaborator

marmg commented Oct 4, 2023

Thank you @ab3llini. I have removed the version constraint, as it should already work with torch==2.0. I will merge the PR as soon as possible.

Regarding a new release, we plan to release a new version soon, but we want to finish some things first. I will ping you when ready. Until then, you can install it from the git master branch:
pip install git+https://github.com/IBM/zshot.git@main

@marmg marmg closed this as completed in #71 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants