fix: added support for winrm_password for windows custom images (#114)

* Added winrm_login_password support

Signed-off-by: Ujjwal Kumar <ujjwal.kumar1@ibm.com>

* fixed winrm_password attribute

---------

Signed-off-by: Ujjwal Kumar <ujjwal.kumar1@ibm.com>
Co-authored-by: Astha Jain <astha.jain@ibm.com>

Author: uibm

README.md

@@ -225,6 +225,7 @@ ssh_port | int | Optional | The port that SSH will be available on. Defaults to
 ssh_timeout | string | Optional | The time to wait for SSH to become available before timing out. The format of this value is a duration such as "5s" or "5m".
 ***Windows Communicator Variables*** |
 winrm_username | string | Optional | The username to use to connect to WinRM.
+winrm_password | string | Optional | The password to use to connect to WinRM. (For custom windows images)
 winrm_port | int | Optional | The port that WinRM will be available on. Defaults to port 5986.
 winrm_timeout | string | Optional | The time to wait for WinRM to become available before timing out.
 winrm_insecure | bool | Optional | If true, do not check server certificate chain and host name.

builder/ibmcloud/vpc/winRM.go

@@ -16,17 +16,27 @@ func winRMConfig(state multistep.StateBag) (*communicator.WinRMConfig, error) {
 
 	instanceData := state.Get("instance_data").(*vpcv1.Instance)
 	instanceID := *instanceData.ID
+	var username, password string
+	var err error
+
+	if config.Comm.WinRMPassword != "" {
+		username = config.Comm.WinRMUser
+		password = config.Comm.WinRMPassword
+		ui.Say(fmt.Sprintf("Setting provided winrm username and password (ID: %s, IP: %s)", instanceID, config.Comm.WinRMHost))
+
+	} else {
+		// Grabbing credentials for the instance
+		username, password, err = client.GrabCredentials(instanceID, state)
+		if err != nil {
+			err := fmt.Errorf("[ERROR] Error grabbing credentials: %s", err)
+			state.Put("error", err)
+			ui.Error(err.Error())
+			// log.Fatalf(err.Error())
+			return nil, nil
+		}
+		ui.Say(fmt.Sprintf("Successfully grabbed credentials for instance (ID: %s, IP: %s)", instanceID, config.Comm.WinRMHost))
 
-	// Grabbing credentials for the instance
-	username, password, err := client.GrabCredentials(instanceID, state)
-	if err != nil {
-		err := fmt.Errorf("[ERROR] Error grabbing credentials: %s", err)
-		state.Put("error", err)
-		ui.Error(err.Error())
-		// log.Fatalf(err.Error())
-		return nil, nil
 	}
-	ui.Say(fmt.Sprintf("Successfully grabbed credentials for instance (ID: %s, IP: %s)", instanceID, config.Comm.WinRMHost))
 
 	// Configuring WinRM
 	comm := communicator.WinRMConfig{